GPU: Adjust memory and use the soft-limit.

ui/gl/gl_context_android.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/gl/gl_context.h"
 
 #include "base/android/sys_utils.h"
 #include "base/logging.h"
 #include "base/memory/ref_counted.h"
 #include "base/sys_info.h"
@@ skipping 90 matching lines @@
   size_t physical_memory_mb = 0;
   if (dalvik_mb >= 256)
     physical_memory_mb = dalvik_mb * 4;
   else
     physical_memory_mb = std::max(dalvik_mb * 4,
                                   (physical_mb * 4) / 3);
 
   // Now we take a default of 1/8th of memory on high-memory devices,
   // and gradually scale that back for low-memory devices (to be nicer
   // to other apps so they don't get killed). Examples:
-  // Nexus 4/10(2GB)    256MB
-  // Droid Razr M(1GB)  91MB
-  // Galaxy Nexus(1GB)  85MB
-  // Xoom(1GB)          85MB
-  // Nexus S(low-end)   8MB
+  // Nexus 4/10(2GB)    256MB (normally 128MB)
+  // Droid Razr M(1GB)  114MB (normally 57MB)
+  // Galaxy Nexus(1GB)  100MB (normally 50MB)
+  // Xoom(1GB)          100MB (normally 50MB)
+  // Nexus S(low-end)   12MB (normally 8MB)
+  // Note that the compositor now uses only some of this memory for
+  // pre-painting and uses the rest only for 'emergencies'.

[klobag.chromium, 2014/02/15 07:27:20]

Can we move this two lines up and say the number is emergency (pre-painting)? 

[epenner, 2014/02/17 05:43:23]

Yes, much better way to explain the numbers.

   static size_t limit_bytes = 0;
   if (limit_bytes == 0) {
+    // NOTE: Non-low-end devices use only 50% of these limits,
+    // except during 'emergencies' where 100% can be used.
     if (!base::android::SysUtils::IsLowEndDevice()) {
       if (physical_memory_mb >= 1536)
-        limit_bytes = physical_memory_mb / 8;
+        limit_bytes = physical_memory_mb / 8; // >192MB
       else if (physical_memory_mb >= 1152)
-        limit_bytes = physical_memory_mb / 10;
+        limit_bytes = physical_memory_mb / 8; // >144MB

[klobag.chromium, 2014/02/15 07:27:20]

merge the above two?

[epenner, 2014/02/17 05:43:23]

Good point will do. I think this number is common way to differentiate some
devices, but no longer useful here.

       else if (physical_memory_mb >= 768)
-        limit_bytes = physical_memory_mb / 12;
+        limit_bytes = physical_memory_mb / 10; // >76MB
       else
-        limit_bytes = physical_memory_mb / 16;
+        limit_bytes = physical_memory_mb / 12; // <64MB
     } else {
       // Low-end devices have 512MB or less memory by definition
       // so we hard code the limit rather than relying on the heuristics
       // above. Low-end devices use 4444 textures so we can use a lower limit.
-      limit_bytes = 8;
+      // NOTE: Low-end uses 2/3 (67%) of this memory in practice, so we have
+      // increased the limit to 12 (8MB, or 12MB in emergencies).
+      limit_bytes = 12;
     }
     limit_bytes = limit_bytes * 1024 * 1024;
   }
   *bytes = limit_bytes;
   return true;
 }
 
 }