Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(565)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1680523002: start experimenting with 64bit frame-buffers (Closed)

Created:
4 years, 10 months ago by reed2
Modified:
4 years, 10 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : impl N versions #

Unified diffs Side-by-side diffs Delta from patch set Stats (+452 lines, -0 lines) Patch
A bench/XferU64Bench.cpp View 1 2 3 4 1 chunk +106 lines, -0 lines 0 comments Download
A gm/xferu64.cpp View 1 2 3 4 1 chunk +149 lines, -0 lines 0 comments Download
M gyp/core.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M include/core/SkXfermode.h View 1 2 3 4 1 chunk +15 lines, -0 lines 0 comments Download
A src/core/SkXfermodeU64.cpp View 1 2 3 4 1 chunk +181 lines, -0 lines 0 comments Download

Messages

Total messages: 24 (12 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1680523002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1680523002/1
4 years, 10 months ago (2016-02-06 20:48:58 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Win-MSVC-x86-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-Debug-Trybot/builds/5961) Build-Win-MSVC-x86_64-Debug-Trybot on ...
4 years, 10 months ago (2016-02-06 20:53:37 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1680523002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1680523002/40001
4 years, 10 months ago (2016-02-07 04:01:38 UTC) #7
reed2
4x faster w/ your change, but now I seem to be getting 0 when I ...
4 years, 10 months ago (2016-02-07 04:02:51 UTC) #9
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Win-MSVC-x86-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-Debug-Trybot/builds/5968) Build-Win-MSVC-x86_64-Debug-Trybot on ...
4 years, 10 months ago (2016-02-07 04:04:37 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1680523002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1680523002/60001
4 years, 10 months ago (2016-02-07 04:26:08 UTC) #13
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-07 05:03:59 UTC) #15
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1680523002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1680523002/80001
4 years, 10 months ago (2016-02-08 00:51:39 UTC) #17
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-08 01:55:59 UTC) #19
mtklein
lgtm
4 years, 10 months ago (2016-02-09 16:42:42 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1680523002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1680523002/80001
4 years, 10 months ago (2016-02-09 16:42:46 UTC) #22
commit-bot: I haz the power
4 years, 10 months ago (2016-02-09 17:15:02 UTC) #24
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/d2ed622a2fc574288b312ec1ff94c77ed6e70476

Powered by Google App Engine
This is Rietveld 408576698