Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1680503002: Tidy up inclusion of WebScheduler.h (Closed)

Created:
4 years, 10 months ago by sof
Modified:
4 years, 10 months ago
Reviewers:
haraken
CC:
chromium-reviews, tyoshino+watch_chromium.org, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, gavinp+loader_chromium.org, blink-reviews, loading-reviews+fetch_chromium.org, kinuko+watch, Nate Chapin, scheduler-bugs_chromium.org, loading-reviews_chromium.org, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Tidy up inclusion of WebScheduler.h Hygiene; insist on IWYU for WebScheduler.h also. R=haraken BUG= Committed: https://crrev.com/d418d6a8b2157400355d882c7ae839df517b6a29 Cr-Commit-Position: refs/heads/master@{#374055}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M third_party/WebKit/Source/core/dom/Document.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/Resource.cpp View 3 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/loader/NavigationScheduler.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/CancellableTaskFactory.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/CancellableTaskFactory.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/scheduler/CancellableTaskFactoryTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
sof
please take a look.
4 years, 10 months ago (2016-02-06 21:41:56 UTC) #2
haraken
LGTM
4 years, 10 months ago (2016-02-07 01:53:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1680503002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1680503002/1
4 years, 10 months ago (2016-02-07 16:11:13 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-07 16:15:25 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2016-02-07 16:16:09 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/d418d6a8b2157400355d882c7ae839df517b6a29
Cr-Commit-Position: refs/heads/master@{#374055}

Powered by Google App Engine
This is Rietveld 408576698