Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Side by Side Diff: xfa/src/fxfa/src/parser/xfa_layout_appadapter.cpp

Issue 1680463002: Fix heap-use-after-free in CXFA_FFWidget::GetDataAcc() (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 PDFium Authors. All rights reserved. 1 // Copyright 2014 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com 5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
6 6
7 #include "xfa/src/foxitlib.h" 7 #include "xfa/src/foxitlib.h"
8 #include "xfa/src/fxfa/src/common/xfa_utils.h" 8 #include "xfa/src/fxfa/src/common/xfa_utils.h"
9 #include "xfa/src/fxfa/src/common/xfa_object.h" 9 #include "xfa/src/fxfa/src/common/xfa_object.h"
10 #include "xfa/src/fxfa/src/common/xfa_document.h" 10 #include "xfa/src/fxfa/src/common/xfa_document.h"
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
45 IXFA_DocLayout* pDocLayout = 45 IXFA_DocLayout* pDocLayout =
46 pLayoutItem->m_pFormNode->GetDocument()->GetDocLayout(); 46 pLayoutItem->m_pFormNode->GetDocument()->GetDocLayout();
47 while (pNode) { 47 while (pNode) {
48 CXFA_LayoutItem* pNext = pNode->m_pNextSibling; 48 CXFA_LayoutItem* pNext = pNode->m_pNextSibling;
49 pNode->m_pParent = nullptr; 49 pNode->m_pParent = nullptr;
50 pNotify->OnLayoutEvent(pDocLayout, static_cast<CXFA_LayoutItem*>(pNode), 50 pNotify->OnLayoutEvent(pDocLayout, static_cast<CXFA_LayoutItem*>(pNode),
51 XFA_LAYOUTEVENT_ItemRemoving); 51 XFA_LAYOUTEVENT_ItemRemoving);
52 XFA_ReleaseLayoutItem(pNode); 52 XFA_ReleaseLayoutItem(pNode);
53 pNode = pNext; 53 pNode = pNext;
54 } 54 }
55 pNotify->OnLayoutEvent(pDocLayout, pLayoutItem, XFA_LAYOUTEVENT_ItemRemoving);
jun_fang 2016/02/06 03:49:27 The information about destroy of pLayoutItem shoul
55 if (pLayoutItem->m_pFormNode->GetClassID() == XFA_ELEMENT_PageArea) { 56 if (pLayoutItem->m_pFormNode->GetClassID() == XFA_ELEMENT_PageArea) {
56 pNotify->OnPageEvent(static_cast<CXFA_ContainerLayoutItem*>(pLayoutItem), 57 pNotify->OnPageEvent(static_cast<CXFA_ContainerLayoutItem*>(pLayoutItem),
57 XFA_PAGEEVENT_PageRemoved); 58 XFA_PAGEEVENT_PageRemoved);
58 } 59 }
59 delete pLayoutItem; 60 delete pLayoutItem;
60 } 61 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698