Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1680433002:
Skip installation of UCRT (Closed)
|
Created:
4 years, 10 months ago by brucedawson Modified:
4 years, 10 months ago CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master Target Ref:
refs/heads/master Project:
depot_tools Visibility:
Public. |
DescriptionSkip installation of UCRT
The UCRT is now optional and it failed to install on one builder.
Making optional to fix build break
If this doesn't fix the break on the waterfall then the switch
to VS 2015 will need to be reverted (crrev.com/1598493004).
I'm (after commit) assigning this as part of crbug.com/495944. The
error code was 80240017 which implies a corrupt or at least bad
Windows update state, rather than a permissions error.
TBR=scottmg@chromium.org
BUG=440500
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298634
Patch Set 1 #
Messages
Total messages: 25 (12 generated)
Description was changed from ========== Skip installation of UCRT The UCRT is now optional and it failed to install on one builder. Making optional to fix build break BUG=440500 ========== to ========== Skip installation of UCRT The UCRT is now optional and it failed to install on one builder. Making optional to fix build break If this doesn't fix the break on the waterfall then the switch to VS 2015 will need to be reverted (crrev.com/1598493004). TBR=scottmg@chromium.org BUG=440500 ==========
The CQ bit was checked by brucedawson@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1680433002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1680433002/1
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. Committers are members of the group "project-infra-committers". Note that this has nothing to do with OWNERS files.
LGTM
The CQ bit was checked by brucedawson@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1680433002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1680433002/1
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. Committers are members of the group "project-infra-committers". Note that this has nothing to do with OWNERS files.
On 2016/02/06 01:59:48, commit-bot: I haz the power wrote: > No L-G-T-M from a valid reviewer yet. Only full committers are accepted. > Even if an L-G-T-M may have been provided, it was from a non-committer, > _not_ a full super star committer. > Committers are members of the group "project-infra-committers". > Note that this has nothing to do with OWNERS files. lgtm
The CQ bit was checked by brucedawson@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1680433002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1680433002/1
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. Committers are members of the group "project-infra-committers". Note that this has nothing to do with OWNERS files.
thakis@chromium.org changed reviewers: + thakis@chromium.org
rs-lgtm
The CQ bit was checked by wfh@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1680433002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1680433002/1
Message was sent while issue was closed.
Description was changed from ========== Skip installation of UCRT The UCRT is now optional and it failed to install on one builder. Making optional to fix build break If this doesn't fix the break on the waterfall then the switch to VS 2015 will need to be reverted (crrev.com/1598493004). TBR=scottmg@chromium.org BUG=440500 ========== to ========== Skip installation of UCRT The UCRT is now optional and it failed to install on one builder. Making optional to fix build break If this doesn't fix the break on the waterfall then the switch to VS 2015 will need to be reverted (crrev.com/1598493004). TBR=scottmg@chromium.org BUG=440500 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298634 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as http://src.chromium.org/viewvc/chrome?view=rev&revision=298634
Message was sent while issue was closed.
scottmg@chromium.org changed reviewers: + scottmg@chromium.org
Message was sent while issue was closed.
lgtm
Message was sent while issue was closed.
Description was changed from ========== Skip installation of UCRT The UCRT is now optional and it failed to install on one builder. Making optional to fix build break If this doesn't fix the break on the waterfall then the switch to VS 2015 will need to be reverted (crrev.com/1598493004). TBR=scottmg@chromium.org BUG=440500 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298634 ========== to ========== Skip installation of UCRT The UCRT is now optional and it failed to install on one builder. Making optional to fix build break If this doesn't fix the break on the waterfall then the switch to VS 2015 will need to be reverted (crrev.com/1598493004). I'm (after commit) assigning this as part of crbug.com/495944. The error code was 80240017 which implies a corrupt or at least bad Windows update state, rather than a permissions error. TBR=scottmg@chromium.org BUG=440500 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298634 ==========
Message was sent while issue was closed.
On 2016/02/06 03:34:34, scottmg (afk until tues 9feb) wrote: > lgtm I'm (after commit) assigning this as part of crbug.com/495944. The error code was 80240017 which implies a corrupt or at least bad Windows update state, rather than a permissions error. That's why it wasn't caught by the exception handler. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
