Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(505)

Issue 1680403003: Incrementally update incompletely resolved units. (Closed)

Created:
4 years, 10 months ago by scheglov
Modified:
4 years, 10 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Incrementally update incompletely resolved units. When the context A uses unit U from the context B, we don't resolve U in A to RESOLVED_UNIT, we usually stop somewhere before. But we still want to update U in A incrementally. We don't put RESOLVED_UNITx results into cache, so we don't write a less resolved unit as a more resolved result. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/da0a022962839849b3edefaffca343850339fcf6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -7 lines) Patch
M pkg/analyzer/lib/src/context/context.dart View 3 chunks +28 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 10 months ago (2016-02-10 17:50:39 UTC) #1
Brian Wilkerson
LGTM
4 years, 10 months ago (2016-02-10 18:49:03 UTC) #2
scheglov
4 years, 10 months ago (2016-02-10 19:35:08 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
da0a022962839849b3edefaffca343850339fcf6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698