Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 168033002: Fixing utf8 issue with kiosk mode message (Closed)

Created:
6 years, 10 months ago by Mr4D (OOO till 08-26)
Modified:
6 years, 10 months ago
Reviewers:
oshima
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

Fixing utf8 issue with kiosk mode message BUG=343715 TEST=visual Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251540

Patch Set 1 #

Patch Set 2 : Probles uploading #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/chromeos/ui/idle_app_name_notification_view.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
Mr4D (OOO till 08-26)
Please have a look!
6 years, 10 months ago (2014-02-15 00:32:39 UTC) #1
oshima
lgtm
6 years, 10 months ago (2014-02-15 00:39:02 UTC) #2
Mr4D (OOO till 08-26)
The CQ bit was checked by skuhne@chromium.org
6 years, 10 months ago (2014-02-15 00:42:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skuhne@chromium.org/168033002/150001
6 years, 10 months ago (2014-02-15 00:59:46 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-15 02:39:14 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=264929
6 years, 10 months ago (2014-02-15 02:39:14 UTC) #6
Mr4D (OOO till 08-26)
The CQ bit was checked by skuhne@chromium.org
6 years, 10 months ago (2014-02-15 03:12:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skuhne@chromium.org/168033002/150001
6 years, 10 months ago (2014-02-15 03:13:17 UTC) #8
commit-bot: I haz the power
6 years, 10 months ago (2014-02-15 05:31:57 UTC) #9
Message was sent while issue was closed.
Change committed as 251540

Powered by Google App Engine
This is Rietveld 408576698