tool/input_sdk/private/operations.dart - Issue 1680263002: Support for dart:typed_data

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tool/input_sdk/private/operations.dart

Issue 1680263002: Support for dart:typed_data (Closed) Base URL: https://github.com/dart-lang/dev_compiler.git@master

Patch Set: Address comments, rebase Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tool/input_sdk/private/operations.dart

diff --git a/tool/input_sdk/private/operations.dart b/tool/input_sdk/private/operations.dart

index a79fc5bea998bc37c57deb7f6a4a0b9282eaad1a..dcac6ff47eb4f0dfd201a17b0b965e3332a74f37 100644

--- a/tool/input_sdk/private/operations.dart

+++ b/tool/input_sdk/private/operations.dart

@@ -165,7 +165,8 @@ _ignoreTypeFailure(actual, type) => JS('', '''(() => {

strongInstanceOf(obj, type, ignoreFromWhiteList) => JS('', '''(() => {

let actual = $realRuntimeType($obj);

- if ($isSubtype(actual, $type) || actual == $jsobject) return true;

+ if ($isSubtype(actual, $type) || actual == $jsobject ||

+ actual == $int && type == $double) return true;

if ($ignoreFromWhiteList == void 0) return false;

if ($isGroundType($type)) return false;

if ($_ignoreTypeFailure(actual, $type)) return true;

« no previous file with comments | « tool/input_sdk/private/native_typed_data.dart ('k') | tool/input_sdk/private/rtti.dart » ('j') | no next file with comments »