lib/src/codegen/module_builder.dart - Issue 1680263002: Support for dart:typed_data

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/src/codegen/module_builder.dart

Issue 1680263002: Support for dart:typed_data (Closed) Base URL: https://github.com/dart-lang/dev_compiler.git@master

Patch Set: Address comments, rebase Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: lib/src/codegen/module_builder.dart

diff --git a/lib/src/codegen/module_builder.dart b/lib/src/codegen/module_builder.dart

index e34efc87b445aa35290a41e2218b4d49777863cb..6e20cd314727b76c5f59a389596eeff6de120a6d 100644

--- a/lib/src/codegen/module_builder.dart

+++ b/lib/src/codegen/module_builder.dart

@@ -155,8 +155,7 @@ class ES6ModuleBuilder extends ModuleBuilder {

.add(js.statement('#.# = #;', [exportsVar, exportName, name]));

});

}

- moduleStatements

- .add(new JS.ExportDeclaration(exportsVar, isDefault: true));

+ moduleStatements.add(new JS.ExportDeclaration(exportsVar, isDefault: true));

// TODO(ochafik): What to do with jsModuleValue?

return new JS.Program(moduleStatements);

}

« no previous file with comments | « lib/src/codegen/js_interop.dart ('k') | test/browser/language_tests.js » ('j') | no next file with comments »