Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1680243005: Make QUIC tests use certs which are valid for the hosts they connect to. (Closed)

Created:
4 years, 10 months ago by Ryan Hamilton
Modified:
4 years, 10 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make QUIC tests use certs which are valid for the hosts they connect to. BUG= Committed: https://crrev.com/9ae5b3b99a36cdb66409727df2297f458ff6d0a4 Cr-Commit-Position: refs/heads/master@{#374803}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -103 lines) Patch
M net/quic/quic_http_stream_test.cc View 17 chunks +17 lines, -17 lines 0 comments Download
M net/quic/quic_network_transaction_unittest.cc View 36 chunks +72 lines, -75 lines 0 comments Download
M net/quic/test_tools/mock_crypto_client_stream.h View 3 chunks +10 lines, -7 lines 0 comments Download
M net/quic/test_tools/mock_crypto_client_stream.cc View 2 chunks +13 lines, -1 line 0 comments Download
M net/quic/test_tools/mock_crypto_client_stream_factory.h View 3 chunks +4 lines, -2 lines 0 comments Download
M net/quic/test_tools/mock_crypto_client_stream_factory.cc View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Issue 1683313002 Patch 40001
Issue 1683313002 Patch 60001

Messages

Total messages: 8 (3 generated)
Ryan Hamilton
4 years, 10 months ago (2016-02-10 23:26:19 UTC) #2
ramant (doing other things)
lgtm
4 years, 10 months ago (2016-02-10 23:34:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1680243005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1680243005/1
4 years, 10 months ago (2016-02-10 23:37:17 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-11 00:36:39 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:33:11 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/9ae5b3b99a36cdb66409727df2297f458ff6d0a4
Cr-Commit-Position: refs/heads/master@{#374803}

Powered by Google App Engine
This is Rietveld 408576698