Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(877)

Issue 1680213002: Start using deferred rendering for WebView on L.

Created:
4 years, 10 months ago by liberato (no reviews please)
Modified:
4 years, 9 months ago
Reviewers:
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@measure_copy
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Start using deferred rendering for WebView on L. When running with the synchronous compositor (i.e., WebView), the deferred rendering strategy requests that all video frames are to be copied before being sent to the browser compositor. This is required for compatibility with the lack of context sharing in WebView. It has the benefit over using the copying strategy that it keeps only ~2 copies at once, rather than 4-5. Android L supports SurfaceTexture onFrameAvailable callbacks on user-chosen threads. This allows us to avoid a deadlock with the browser compositor. Prior to L, we continue to use the copying strategy to avoid the problem instead. BUG=582170

Patch Set 1 #

Patch Set 2 : hopefully fixed windows compile, rebased. #

Patch Set 3 : still trying to make windows compile. #

Patch Set 4 : cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+203 lines, -11 lines) Patch
M content/common/gpu/media/android_video_decode_accelerator.h View 1 2 3 1 chunk +8 lines, -0 lines 0 comments Download
M content/common/gpu/media/android_video_decode_accelerator.cc View 1 2 3 5 chunks +59 lines, -9 lines 0 comments Download
M media/filters/gpu_video_decoder.h View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M media/filters/gpu_video_decoder.cc View 1 2 3 3 chunks +6 lines, -0 lines 0 comments Download
M media/video/video_decode_accelerator.h View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M ui/android/java/src/org/chromium/ui/gl/SurfaceTexturePlatformWrapper.java View 1 2 3 4 chunks +107 lines, -2 lines 0 comments Download
M ui/gl/android/surface_texture.h View 1 chunk +8 lines, -0 lines 0 comments Download
M ui/gl/android/surface_texture.cc View 1 chunk +8 lines, -0 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698