Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Side by Side Diff: sdk/lib/_internal/compiler/implementation/ssa/builder.dart

Issue 16802004: Fix host-checked mode error in dart2js by removing bad assertion. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | tests/language/aborting_switch_case_test.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 part of ssa; 5 part of ssa;
6 6
7 /** 7 /**
8 * A special element for the extra parameter taken by intercepted 8 * A special element for the extra parameter taken by intercepted
9 * methods. We need to override [Element.computeType] because our 9 * methods. We need to override [Element.computeType] because our
10 * optimizers may look at its declared type. 10 * optimizers may look at its declared type.
(...skipping 1927 matching lines...) Expand 10 before | Expand all | Expand 10 after
1938 } 1938 }
1939 assert(!current.isClosed()); 1939 assert(!current.isClosed());
1940 if (!stack.isEmpty) compiler.cancel('non-empty instruction stack'); 1940 if (!stack.isEmpty) compiler.cancel('non-empty instruction stack');
1941 } 1941 }
1942 1942
1943 visitClassNode(ClassNode node) { 1943 visitClassNode(ClassNode node) {
1944 compiler.internalError('visitClassNode should not be called', node: node); 1944 compiler.internalError('visitClassNode should not be called', node: node);
1945 } 1945 }
1946 1946
1947 visitExpressionStatement(ExpressionStatement node) { 1947 visitExpressionStatement(ExpressionStatement node) {
1948 assert(isReachable); 1948 if (!isReachable) return;
1949 Throw throwExpression = node.expression.asThrow(); 1949 Throw throwExpression = node.expression.asThrow();
1950 if (throwExpression != null && inliningStack.isEmpty) { 1950 if (throwExpression != null && inliningStack.isEmpty) {
1951 visit(throwExpression.expression); 1951 visit(throwExpression.expression);
1952 handleInTryStatement(); 1952 handleInTryStatement();
1953 closeAndGotoExit(new HThrow(pop())); 1953 closeAndGotoExit(new HThrow(pop()));
1954 } else { 1954 } else {
1955 visit(node.expression); 1955 visit(node.expression);
1956 pop(); 1956 pop();
1957 } 1957 }
1958 } 1958 }
(...skipping 3421 matching lines...) Expand 10 before | Expand all | Expand 10 after
5380 new HSubGraphBlockInformation(elseBranch.graph)); 5380 new HSubGraphBlockInformation(elseBranch.graph));
5381 5381
5382 HBasicBlock conditionStartBlock = conditionBranch.block; 5382 HBasicBlock conditionStartBlock = conditionBranch.block;
5383 conditionStartBlock.setBlockFlow(info, joinBlock); 5383 conditionStartBlock.setBlockFlow(info, joinBlock);
5384 SubGraph conditionGraph = conditionBranch.graph; 5384 SubGraph conditionGraph = conditionBranch.graph;
5385 HIf branch = conditionGraph.end.last; 5385 HIf branch = conditionGraph.end.last;
5386 assert(branch is HIf); 5386 assert(branch is HIf);
5387 branch.blockInformation = conditionStartBlock.blockFlow; 5387 branch.blockInformation = conditionStartBlock.blockFlow;
5388 } 5388 }
5389 } 5389 }
OLDNEW
« no previous file with comments | « no previous file | tests/language/aborting_switch_case_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698