Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Issue 1680183002: Move pathLength scale-factor computation to SVGPathElement (Closed)

Created:
4 years, 10 months ago by fs
Modified:
4 years, 10 months ago
CC:
fs, blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, krit, eae+blinkwatch, f(malita), gyuyoung2, jchaffraix+rendering, kouhei+svg_chromium.org, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move pathLength scale-factor computation to SVGPathElement There'll eventually be more users of it. Maybe by means of the bug referenced below. BUG=366559 Committed: https://crrev.com/233aa75282a727b00668c445ca5a3c02fe6ccc84 Cr-Commit-Position: refs/heads/master@{#374446}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -23 lines) Patch
M third_party/WebKit/Source/core/layout/svg/LayoutSVGShape.cpp View 1 chunk +3 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGPathElement.h View 3 chunks +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGPathElement.cpp View 1 chunk +23 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
fs
4 years, 10 months ago (2016-02-09 19:17:12 UTC) #2
f(malita)
lgtm
4 years, 10 months ago (2016-02-09 19:41:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1680183002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1680183002/1
4 years, 10 months ago (2016-02-09 20:09:29 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-09 20:20:03 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-09 20:21:53 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/233aa75282a727b00668c445ca5a3c02fe6ccc84
Cr-Commit-Position: refs/heads/master@{#374446}

Powered by Google App Engine
This is Rietveld 408576698