third_party/WebKit/Source/core/html/forms/CheckboxInputType.cpp - Issue 1680143002: Simulate click through gamepad BUTTON_A

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/forms/CheckboxInputType.cpp

Issue 1680143002: Simulate click through gamepad BUTTON_A (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/forms/CheckboxInputType.cpp

diff --git a/third_party/WebKit/Source/core/html/forms/CheckboxInputType.cpp b/third_party/WebKit/Source/core/html/forms/CheckboxInputType.cpp

index fee27cc78d5dc78c5a2f4c21417a82dd7aca7aa6..6c3244a7e3c8fd7e4897cc3912c87e40f0ed1c1d 100644

--- a/third_party/WebKit/Source/core/html/forms/CheckboxInputType.cpp

+++ b/third_party/WebKit/Source/core/html/forms/CheckboxInputType.cpp

@@ -62,7 +62,7 @@ String CheckboxInputType::valueMissingText() const

void CheckboxInputType::handleKeyupEvent(KeyboardEvent* event)

{

const String& key = event->keyIdentifier();

- if (key != "U+0020")

+ if (key != "U+0020" && key != "Enter")

return;

dispatchSimulatedClickIfActive(event);

}