Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Issue 1680133002: [proxies] Implement spec change to consistency check in [[SetPrototypeOf]]. (Closed)

Created:
4 years, 10 months ago by neis
Modified:
4 years, 10 months ago
Reviewers:
rossberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[proxies] Implement spec change to consistency check in [[SetPrototypeOf]]. See https://github.com/tc39/ecma262/pull/331. R=rossberg BUG= Committed: https://crrev.com/ff97dc820d325180d0efbb113dfa91ecb6a2afe4 Cr-Commit-Position: refs/heads/master@{#33855}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -10 lines) Patch
M src/objects.cc View 1 chunk +12 lines, -10 lines 0 comments Download
M test/mjsunit/harmony/proxies-set-prototype-of.js View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
neis
4 years, 10 months ago (2016-02-09 12:30:55 UTC) #1
rossberg
lgtm
4 years, 10 months ago (2016-02-09 18:42:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1680133002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1680133002/1
4 years, 10 months ago (2016-02-10 07:48:29 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-10 08:07:09 UTC) #5
commit-bot: I haz the power
4 years, 10 months ago (2016-02-10 08:07:50 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ff97dc820d325180d0efbb113dfa91ecb6a2afe4
Cr-Commit-Position: refs/heads/master@{#33855}

Powered by Google App Engine
This is Rietveld 408576698