Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Unified Diff: sdk/bin/pub

Issue 168013003: Give the VM more heap in pub (on Mac/Linux). (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sdk/bin/pub_developer » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/bin/pub
diff --git a/sdk/bin/pub b/sdk/bin/pub
index 42f84fce029f3bf86b7b05916877c25dc8158b27..100a15ba22c8452937831d021790e60755b41a85 100755
--- a/sdk/bin/pub
+++ b/sdk/bin/pub
@@ -25,10 +25,23 @@ SDK_DIR="$(cd "${BIN_DIR}/.." ; pwd -P)"
SNAPSHOT="$BIN_DIR/snapshots/pub.dart.snapshot"
+unset VM_OPTIONS
+declare -a VM_OPTIONS
+
+# Give the VM extra memory for dart2js.
+# TODO(rnystrom): Remove when #8355 is fixed.
+VM_OPTIONS+=("--old_gen_heap_size=1024")
+
+# Allow extra VM options to be passed in through an environment variable.
+if [[ $DART_VM_OPTIONS ]]; then
+ read -a OPTIONS <<< "$DART_VM_OPTIONS"
+ VM_OPTIONS+=("${OPTIONS[@]}")
+fi
nweiz 2014/02/15 01:00:52 I hope you've manually tested this thoroughly, bec
Bob Nystrom 2014/02/18 17:36:27 It's copied verbatim from the dart2js script, modu
+
if test -f "$SNAPSHOT"; then
# We are running the snapshot in the built SDK.
DART="$BIN_DIR/dart"
- exec "$DART" "$SNAPSHOT" "$@"
+ exec "$DART" "${VM_OPTIONS[@]}" "$SNAPSHOT" "$@"
else
# We are running pub from source in the development repo.
if [ -z "$DART_CONFIGURATION" ];
@@ -50,5 +63,5 @@ else
PUB="$SDK_DIR/lib/_internal/pub/bin/pub.dart"
- exec "$DART" "--package-root=$PACKAGES_DIR" "$PUB" "$@"
+ exec "$DART" "${VM_OPTIONS[@]}" "--package-root=$PACKAGES_DIR" "$PUB" "$@"
fi
« no previous file with comments | « no previous file | sdk/bin/pub_developer » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698