Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(462)

Issue 1680103003: Match the derived features to the training data set (Closed)

Created:
4 years, 10 months ago by wychen
Modified:
4 years, 10 months ago
Reviewers:
mdjones
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Match the derived features to the training data set The length of the last segment of the url calculated in Chrome was different from the training script here (http://crrev.com/1620043002/). TEST=components_unittests --gtest_filter="DomDistillerPageFeaturesTest.*" Committed: https://crrev.com/9bad2faf07597a159f79d41b01f6cadf6a797d26 Cr-Commit-Position: refs/heads/master@{#374587}

Patch Set 1 #

Patch Set 2 : style #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -2 lines) Patch
M components/dom_distiller/core/page_features.cc View 1 1 chunk +5 lines, -1 line 0 comments Download
M components/dom_distiller/core/page_features_unittest.cc View 1 chunk +21 lines, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
wychen
PTAL
4 years, 10 months ago (2016-02-10 01:11:45 UTC) #3
mdjones
lgtm
4 years, 10 months ago (2016-02-10 01:28:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1680103003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1680103003/20001
4 years, 10 months ago (2016-02-10 01:52:42 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-10 02:55:05 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2016-02-10 02:56:49 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9bad2faf07597a159f79d41b01f6cadf6a797d26
Cr-Commit-Position: refs/heads/master@{#374587}

Powered by Google App Engine
This is Rietveld 408576698