Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(507)

Unified Diff: tests/lib/async/run_zoned5_test.dart

Issue 16801008: catchErrors and waitForCompletion now based on runZonedExperimental. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Rebase. Comments. error-handler does not use boolean result. Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/lib/async/run_zoned5_test.dart
diff --git a/tests/lib/async/catch_errors_test.dart b/tests/lib/async/run_zoned5_test.dart
similarity index 61%
copy from tests/lib/async/catch_errors_test.dart
copy to tests/lib/async/run_zoned5_test.dart
index 08ed6f50b3421e4f45f0cdd33a2c5f1648f56ecc..bfe7c8b0afd1c338753b52256b8a08901eb7d6e0 100644
--- a/tests/lib/async/catch_errors_test.dart
+++ b/tests/lib/async/run_zoned5_test.dart
@@ -10,14 +10,10 @@ main() {
// We keep a ReceivePort open until all tests are done. This way the VM will
// hang if the callbacks are not invoked and the test will time out.
var port = new ReceivePort();
- // Make sure `catchErrors` shuts down the error stream when the synchronous
- // operation is done and there isn't any asynchronous pending callback.
- catchErrors(() {
- return 'allDone';
- }).listen((x) {
- Expect.fail("Unexpected callback");
- },
- onDone: () {
- port.close();
- });
+ // Ensure that `runZoned`'s onError handles synchronous errors.
+ runZonedExperimental(() { throw 0; },
+ onError: (e) {
+ Expect.equals(0, e);
+ port.close();
+ });
}

Powered by Google App Engine
This is Rietveld 408576698