Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1680033004: Move gtk-specific browser main parts stuff to its own file. (Closed)

Created:
4 years, 10 months ago by Evan Stade
Modified:
4 years, 10 months ago
Reviewers:
sky
CC:
chromium-reviews, kalyank, sadrul, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move gtk-specific browser main parts stuff to its own file. BUG=none Committed: https://crrev.com/d3aa0e87b3342365ba4eded7e3d0f1eb2de50f6d Cr-Commit-Position: refs/heads/master@{#376017}

Patch Set 1 #

Patch Set 2 : get rid of ExtraPartsAura completely #

Patch Set 3 : compile cros (_gtk ignored?) #

Patch Set 4 : move to libgtk2ui #

Total comments: 2

Patch Set 5 : dependencies #

Patch Set 6 : move files again in attempt to resolve dependency graph #

Patch Set 7 : rebase, fix ToolkitInitialized() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+166 lines, -209 lines) Patch
M chrome/browser/DEPS View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 2 3 4 5 6 3 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/ui/aura/chrome_browser_main_extra_parts_aura.h View 1 1 chunk +0 lines, -36 lines 0 comments Download
D chrome/browser/ui/aura/chrome_browser_main_extra_parts_aura.cc View 1 2 3 4 5 6 1 chunk +0 lines, -162 lines 0 comments Download
M chrome/browser/ui/views/DEPS View 4 5 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/chrome_browser_main_extra_parts_views.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/chrome_browser_main_extra_parts_views.cc View 1 2 2 chunks +8 lines, -0 lines 0 comments Download
A chrome/browser/ui/views/chrome_browser_main_extra_parts_views_linux.h View 1 2 3 4 5 1 chunk +30 lines, -0 lines 0 comments Download
A chrome/browser/ui/views/chrome_browser_main_extra_parts_views_linux.cc View 1 2 3 4 5 6 1 chunk +116 lines, -0 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 26 (11 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1680033004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1680033004/40001
4 years, 10 months ago (2016-02-10 02:12:49 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/144566)
4 years, 10 months ago (2016-02-10 02:26:33 UTC) #4
Evan Stade
https://codereview.chromium.org/1680033004/diff/60001/chrome/browser/ui/views/chrome_browser_main_extra_parts_views.cc File chrome/browser/ui/views/chrome_browser_main_extra_parts_views.cc (right): https://codereview.chromium.org/1680033004/diff/60001/chrome/browser/ui/views/chrome_browser_main_extra_parts_views.cc#newcode32 chrome/browser/ui/views/chrome_browser_main_extra_parts_views.cc:32: #if defined(USE_AURA) is this still necessary? Does views not ...
4 years, 10 months ago (2016-02-10 22:34:53 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1680033004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1680033004/60001
4 years, 10 months ago (2016-02-10 22:34:54 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/144931)
4 years, 10 months ago (2016-02-10 22:44:17 UTC) #10
sky
LGTM https://codereview.chromium.org/1680033004/diff/60001/chrome/browser/ui/views/chrome_browser_main_extra_parts_views.cc File chrome/browser/ui/views/chrome_browser_main_extra_parts_views.cc (right): https://codereview.chromium.org/1680033004/diff/60001/chrome/browser/ui/views/chrome_browser_main_extra_parts_views.cc#newcode32 chrome/browser/ui/views/chrome_browser_main_extra_parts_views.cc:32: #if defined(USE_AURA) On 2016/02/10 22:34:52, Evan Stade wrote: ...
4 years, 10 months ago (2016-02-10 23:23:50 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1680033004/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1680033004/100001
4 years, 10 months ago (2016-02-17 00:55:35 UTC) #13
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/181960)
4 years, 10 months ago (2016-02-17 02:24:41 UTC) #15
Evan Stade
had to move the files around to fix dependencies, PTAL file/class structure
4 years, 10 months ago (2016-02-17 03:39:59 UTC) #16
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1680033004/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1680033004/120001
4 years, 10 months ago (2016-02-17 03:40:51 UTC) #18
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-17 04:34:34 UTC) #20
sky
LGTM
4 years, 10 months ago (2016-02-17 17:33:24 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1680033004/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1680033004/120001
4 years, 10 months ago (2016-02-17 22:46:32 UTC) #23
commit-bot: I haz the power
Committed patchset #7 (id:120001)
4 years, 10 months ago (2016-02-17 22:55:28 UTC) #24
commit-bot: I haz the power
4 years, 10 months ago (2016-02-17 22:56:18 UTC) #26
Message was sent while issue was closed. 
Patchset 7 (id:??) landed as
https://crrev.com/d3aa0e87b3342365ba4eded7e3d0f1eb2de50f6d
Cr-Commit-Position: refs/heads/master@{#376017}

Powered by Google App Engine
This is Rietveld 408576698