Issue 168001: Merge 22642 - Start with a PolicyIgnore when determining navigation action po...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 168001: Merge 22642 - Start with a PolicyIgnore when determining navigation action po... (Closed)

Created:
11 years, 4 months ago by laforge

Modified:
9 years, 7 months ago

Reviewers:
dglazkov, dglazkov1

CC:
chromium-reviews_googlegroups.com, darin (slow to review)

Base URL:
svn://chrome-svn/chrome/branches/195/src/

Visibility:
Public.

Merge 22642 - Start with a PolicyIgnore when determining navigation action policy in WebFrameLoaderClient. This ensures that we never attempt loading an empty URL and fixes the crash in the layout test, mentioned below. BUG=16754 TEST=LayoutTests/fast/loader/emptyembedsrcattribute.html R=darin Review URL: http://codereview.chromium.org/164078 TBR=dglazkov@google.com Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=23263

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -4 lines)			Patch
	MM	webkit/glue/webframeloaderclient_impl.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	MM	webkit/tools/layout_tests/test_expectations.txt	View		1 chunk	+0 lines, -3 lines	0 comments	Download

Total messages: 2 (0 generated)

LGTM.