Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1667)

Issue 1679993002: [Media Router] Adds a contextual menu item to remove the MR component action. (Closed)

Created:
4 years, 10 months ago by mark a. foltz
Modified:
4 years, 10 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2623
Target Ref:
refs/pending/branch-heads/2623
Project:
chromium
Visibility:
Public.

Description

[Media Router] Adds a contextual menu item to remove the MR component action. This adds a menu item to remove the MR component action from the toolbar. It sets a pref so this preference is respected across sessions. The user can restore the action by reinstalling the Cast extension from the Web Store. (They may have to reload the Web Store page immediately after installation to do so.) BUG=576362 TESTED=Unit test, manually tested Review URL: https://codereview.chromium.org/1612203002 Cr-Commit-Position: refs/heads/master@{#371629} (cherry picked from commit 95cfa837a726c4400e025e826fcaddf1bfc751eb) Committed: https://chromium.googlesource.com/chromium/src/+/d533aee7439c6cf2e01de5b540ad10fb9e79ab60

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -25 lines) Patch
M chrome/app/chrome_command_ids.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/component_migration_helper.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/extensions/component_migration_helper.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M chrome/browser/extensions/component_migration_helper_unittest.cc View 1 chunk +18 lines, -0 lines 0 comments Download
M chrome/browser/ui/toolbar/media_router_contextual_menu.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/toolbar/media_router_contextual_menu.cc View 5 chunks +14 lines, -24 lines 0 comments Download
M chrome/browser/ui/toolbar/toolbar_actions_model.h View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
mark a. foltz
4 years, 10 months ago (2016-02-09 00:18:50 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d533aee7439c6cf2e01de5b540ad10fb9e79ab60.

Powered by Google App Engine
This is Rietveld 408576698