Runtime polyfill: Stubbed unimplemented methods; consistency fixes.

Runtime polyfill: Stubbed unimplemented methods; consistency fixes.

This CL contains some fixes for comments to make them consistent across
the polyfills, and explicitly stubs out not implemented functions in the
runtime polyfill.
It also moves the invocation of strict mode into the wrapper function.

Committed: 17e150b31ae1e7ebc726126b6f5a5f1cee33b74f

[Matthew Alger, 2016-02-08 23:01:36]

Description was changed from

==========
Runtime polyfill: Stubbed unimplemented methods; consistency fixes.

This CL contains some fixes for comments to make them consistent across
the polyfills, and explicitly stubs out not implemented functions in the
runtime polyfill.
==========

to

==========
Runtime polyfill: Stubbed unimplemented methods; consistency fixes.

This CL contains some fixes for comments to make them consistent across
the polyfills, and explicitly stubs out not implemented functions in the
runtime polyfill.
It also moves the invocation of strict mode into the wrapper function.
==========

[Matthew Alger, 2016-02-08 23:01:37]

alger@google.com changed reviewers:
+ raymes@chromium.org

[raymes, 2016-02-10 23:10:35]

https://codereview.chromium.org/1679973002/diff/1/src/js/polyfills/runtime.po...
File src/js/polyfills/runtime.polyfill.js (right):

https://codereview.chromium.org/1679973002/diff/1/src/js/polyfills/runtime.po...
src/js/polyfills/runtime.polyfill.js:21: 'use strict';
nit: just move this above function()

https://codereview.chromium.org/1679973002/diff/1/src/js/polyfills/runtime.po...
src/js/polyfills/runtime.polyfill.js:329: addListener: function() {}
Should these throw an exception too?

[Matthew Alger, 2016-02-11 00:15:55]

https://codereview.chromium.org/1679973002/diff/1/src/js/polyfills/runtime.po...
File src/js/polyfills/runtime.polyfill.js (right):

https://codereview.chromium.org/1679973002/diff/1/src/js/polyfills/runtime.po...
src/js/polyfills/runtime.polyfill.js:21: 'use strict';
On 2016/02/10 23:10:35, raymes wrote:
> nit: just move this above function()

Are you sure? This will be included along with other code from the Chrome App
and that code may not be strict. If the invocation is global then strict mode
will be global and we could get script errors in converted apps.

I will change it if you're sure but I'd like to double-check first.

https://codereview.chromium.org/1679973002/diff/1/src/js/polyfills/runtime.po...
src/js/polyfills/runtime.polyfill.js:329: addListener: function() {}
On 2016/02/10 23:10:35, raymes wrote:
> Should these throw an exception too?

Yes. Done.

[raymes, 2016-02-11 05:28:30]

https://codereview.chromium.org/1679973002/diff/1/src/js/polyfills/runtime.po...
File src/js/polyfills/runtime.polyfill.js (right):

https://codereview.chromium.org/1679973002/diff/1/src/js/polyfills/runtime.po...
src/js/polyfills/runtime.polyfill.js:21: 'use strict';
I'm not sure that is true. I think it should only apply to this .js file. I may
be wrong though.

[Matthew Alger, 2016-02-11 22:41:26]

https://codereview.chromium.org/1679973002/diff/1/src/js/polyfills/runtime.po...
File src/js/polyfills/runtime.polyfill.js (right):

https://codereview.chromium.org/1679973002/diff/1/src/js/polyfills/runtime.po...
src/js/polyfills/runtime.polyfill.js:21: 'use strict';
On 2016/02/11 05:28:29, raymes wrote:
> I'm not sure that is true. I think it should only apply to this .js file. I
may
> be wrong though.

Hmm, okay, maybe I'm misreading MDN. I'll update it.

[raymes, 2016-02-15 01:59:56]

lgtm

[Matt Giuca, 2016-02-15 23:56:33]

Description was changed from

==========
Runtime polyfill: Stubbed unimplemented methods; consistency fixes.

This CL contains some fixes for comments to make them consistent across
the polyfills, and explicitly stubs out not implemented functions in the
runtime polyfill.
It also moves the invocation of strict mode into the wrapper function.
==========

to

==========
Runtime polyfill: Stubbed unimplemented methods; consistency fixes.

This CL contains some fixes for comments to make them consistent across
the polyfills, and explicitly stubs out not implemented functions in the
runtime polyfill.
It also moves the invocation of strict mode into the wrapper function.

Committed: 17e150b31ae1e7ebc726126b6f5a5f1cee33b74f
==========

[Matt Giuca, 2016-02-15 23:57:56]

Committed patchset #3 (id:40001) manually as
17e150b31ae1e7ebc726126b6f5a5f1cee33b74f.

(Note: Actually manually, by mgiuca, not using git cl land.)