Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 1679943002: Fix internals method to return Layout Viewport scrollable area for FrameView. (Closed)

Created:
4 years, 10 months ago by ymalik
Modified:
4 years, 10 months ago
Reviewers:
skobes
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix internals method to return Layout Viewport scrollable area for FrameView. Decoupling this change from https://codereview.chromium.org/1648293003/ to unblock https://codereview.chromium.org/1678713002/ BUG=584067 Committed: https://crrev.com/e218a1de18f8004157349c2f948a0a500b4f4694 Cr-Commit-Position: refs/heads/master@{#374249}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/core/testing/Internals.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
ymalik
4 years, 10 months ago (2016-02-08 21:53:34 UTC) #4
skobes
lgtm
4 years, 10 months ago (2016-02-08 22:43:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1679943002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1679943002/1
4 years, 10 months ago (2016-02-08 23:47:54 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-09 01:16:52 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2016-02-09 01:18:12 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e218a1de18f8004157349c2f948a0a500b4f4694
Cr-Commit-Position: refs/heads/master@{#374249}

Powered by Google App Engine
This is Rietveld 408576698