Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Issue 1679923003: Cleanup: Remove MenuEventDispatcher (Closed)

Created:
4 years, 10 months ago by mohsen
Modified:
4 years, 10 months ago
Reviewers:
sadrul
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove MenuEventDispatcher This class is not used anymore after introduction of MenuKeyEventHandler (r348632). Also, removed a forward declaration for DesktopDispatcherClient which does not exist anymore (r372548). BUG=none Committed: https://crrev.com/f5d8cd38d7fc6037d5dc5ae0663103965c5e37f9 Cr-Commit-Position: refs/heads/master@{#374452}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -133 lines) Patch
M ui/views/controls/menu/menu_controller.h View 2 chunks +0 lines, -2 lines 0 comments Download
D ui/views/controls/menu/menu_event_dispatcher.h View 1 chunk +0 lines, -39 lines 0 comments Download
D ui/views/controls/menu/menu_event_dispatcher.cc View 1 chunk +0 lines, -89 lines 0 comments Download
M ui/views/views.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_x11.h View 1 chunk +0 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (3 generated)
mohsen
Please take a look...
4 years, 10 months ago (2016-02-09 03:47:17 UTC) #2
sadrul
lgtm
4 years, 10 months ago (2016-02-09 19:01:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1679923003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1679923003/1
4 years, 10 months ago (2016-02-09 20:16:31 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-09 20:24:12 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-09 20:25:08 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f5d8cd38d7fc6037d5dc5ae0663103965c5e37f9
Cr-Commit-Position: refs/heads/master@{#374452}

Powered by Google App Engine
This is Rietveld 408576698