Issue 1679923002: Resynthesize constructor initializers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1679923002: Resynthesize constructor initializers. (Closed)

Created:
4 years, 10 months ago by scheglov

Modified:
4 years, 10 months ago

Reviewers:
Paul Berry

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Resynthesize constructor initializers. R=paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/1b7a84ce3e0de1c9d9ce061ebbc4804d707e16cc

Patch Set 1 #

Total comments: 1

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+256 lines, -70 lines)			Patch
M	pkg/analyzer/lib/src/generated/testing/element_factory.dart	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/testing/test_type_provider.dart	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	pkg/analyzer/lib/src/summary/resynthesize.dart	View	9 chunks	+87 lines, -8 lines	1 comment	Download
M	pkg/analyzer/test/src/summary/resynthesize_test.dart	View	12 chunks	+161 lines, -62 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Paul Berry

lgtm assuming comment below is addressed. https://codereview.chromium.org/1679923002/diff/1/pkg/analyzer/lib/src/summary/resynthesize.dart File pkg/analyzer/lib/src/summary/resynthesize.dart (right): https://codereview.chromium.org/1679923002/diff/1/pkg/analyzer/lib/src/summary/resynthesize.dart#newcode851 pkg/analyzer/lib/src/summary/resynthesize.dart:851: // constructor.constantInitializers = ...

4 years, 10 months ago (2016-02-08 20:40:56 UTC) #2

scheglov

4 years, 10 months ago (2016-02-08 20:42:37 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
1b7a84ce3e0de1c9d9ce061ebbc4804d707e16cc (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages