components/search_engines/template_url.h - Issue 1679893002: [Contextual Search] Update GetUrlForContextualSearchQuery.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/search_engines/template_url.h

Issue 1679893002: [Contextual Search] Update GetUrlForContextualSearchQuery. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/search_engines/TemplateUrlService.java ('K') | « chrome/browser/search_engines/template_url_service_android.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/search_engines/template_url.h

diff --git a/components/search_engines/template_url.h b/components/search_engines/template_url.h

index 747eb2c05600121912c2bb68254b1155b46f256a..42958ab214edc1e2ff59937d967d834636cc46db 100644

--- a/components/search_engines/template_url.h

+++ b/components/search_engines/template_url.h

@@ -79,13 +79,14 @@ class TemplateURLRef {

ContextualSearchParams();

// Used when the content is sent in the HTTP header instead of as CGI

// parameters.

- // TODO(jeremycho): Remove base_page_url and selection parameters once

+ // TODO(donnd): Remove base_page_url and selection parameters once

// they are logged from the HTTP header.

ContextualSearchParams(const int version,

const std::string& selection,

const std::string& base_page_url,

const bool resolve);

- // TODO(jeremycho): Delete constructor once Clank no longer depends on it.

+ // TODO(donnd): Delete constructor once Clank, iOS, and tests no

+ // longer depend on it.

ContextualSearchParams(const int version,

const size_t start,

const size_t end,