chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchRequest.java - Issue 1679893002: [Contextual Search] Update GetUrlForContextualSearchQuery.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchRequest.java

Issue 1679893002: [Contextual Search] Update GetUrlForContextualSearchQuery. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/search_engines/TemplateUrlService.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/search_engines/TemplateUrlService.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchRequest.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchRequest.java b/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchRequest.java

index e124920aaad76068846ea408a769aff6cce68ef0..e85b9497f7673d15bc0216c29bcb7ec0e9f51c76 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchRequest.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchRequest.java

@@ -35,6 +35,7 @@ class ContextualSearchRequest {

private static final String GWS_QUERY_PARAM = "q";

private static final String CTXS_PARAM_PATTERN = "(ctxs=[^&]+)";

private static final String CTXR_PARAM = "ctxr";

+ private static final String CTXS_TWO_REQUEST_PROTOCOL = "2";

private static final String CTXSL_TRANS_PARAM = "ctxsl_trans";

private static final String CTXSL_TRANS_PARAM_VALUE = "1";

@VisibleForTesting static final String TLITE_SOURCE_LANGUAGE_PARAM = "tlitesl";

@@ -190,7 +191,7 @@ class ContextualSearchRequest {

protected Uri getUriTemplate(String query, @Nullable String alternateTerm,

boolean shouldPrefetch) {

return Uri.parse(TemplateUrlService.getInstance().getUrlForContextualSearchQuery(

- query, alternateTerm, shouldPrefetch));

+ query, alternateTerm, shouldPrefetch, CTXS_TWO_REQUEST_PROTOCOL));

}

/**