Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(660)

Issue 1679813002: [compiler] Remove the special case "prototype" load in class literals. (Closed)

Created:
4 years, 10 months ago by Benedikt Meurer
Modified:
4 years, 10 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[compiler] Remove the special case "prototype" load in class literals. This allows us to remove the somewhat awkward BuildLoadObjectField from the AstGraphBuilder and also allows us to simplify fullcodegen for class literals. R=mstarzinger@chromium.org Committed: https://crrev.com/1ffa4547a7e96bb91757b95ad9193dea2471cc52 Cr-Commit-Position: refs/heads/master@{#33815}

Patch Set 1 #

Patch Set 2 : Fix mips. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -137 lines) Patch
M src/ast/ast.h View 3 chunks +7 lines, -4 lines 0 comments Download
M src/ast/ast.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/compiler/ast-graph-builder.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/ast-graph-builder.cc View 2 chunks +8 lines, -14 lines 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 2 chunks +1 line, -15 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 2 chunks +1 line, -15 lines 0 comments Download
M src/full-codegen/full-codegen.cc View 1 chunk +14 lines, -0 lines 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 2 chunks +0 lines, -14 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 1 2 chunks +1 line, -15 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 2 chunks +1 line, -15 lines 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 2 chunks +0 lines, -15 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 2 chunks +0 lines, -14 lines 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 2 chunks +0 lines, -14 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
4 years, 10 months ago (2016-02-08 12:31:54 UTC) #1
Benedikt Meurer
Hey Michi, Here's the cleanup for the "prototype" access in ClassLiteral. Please appreciate the code ...
4 years, 10 months ago (2016-02-08 12:32:46 UTC) #2
Michael Starzinger
LGTM. I like it!
4 years, 10 months ago (2016-02-08 13:01:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1679813002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1679813002/20001
4 years, 10 months ago (2016-02-08 13:12:07 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-08 13:14:04 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-08 13:14:35 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1ffa4547a7e96bb91757b95ad9193dea2471cc52
Cr-Commit-Position: refs/heads/master@{#33815}

Powered by Google App Engine
This is Rietveld 408576698