Issue 1679783002: Fix for-loop which results in no-op

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1679783002: Fix for-loop which results in no-op (Closed)

Created:
4 years, 10 months ago by hashimoto

Modified:
4 years, 10 months ago

Reviewers:
Lei Zhang

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Fix for-loop which results in no-op The existing code (added in https://codereview.chromium.org/1650793002/) changes the state of a copy of the object. BUG=None

Patch Set 1 #

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

hashimoto

On 2016/02/08 19:07:28, Lei Zhang wrote: > lgtm Lei, Thank you for reviewing this patch. ...

4 years, 10 months ago (2016-02-09 03:53:21 UTC) #5

Lei Zhang

4 years, 10 months ago (2016-02-09 06:21:34 UTC) #6

On 2016/02/09 03:53:21, hashimoto wrote:
> On 2016/02/08 19:07:28, Lei Zhang wrote:
> > lgtm
> 
> Lei,
> 
> Thank you for reviewing this patch.
> I tried to land this patch myself, but it seems I'm not on the list of
approved
> committers of pdfium.
> Could you land this patch on my behalf, or can I be an approved committer?
> 
> Thanks,
> -Ryo

Uploaded https://codereview.chromium.org/1681863002/ for landing / closed this
CL.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages