WTF::bind: Remove the need of hand-rolled code for bound arguments.

WTF::bind: Remove the need of hand-rolled code for bound arguments.

This patch adds a generalized version of PartBoundFunctionImpl for
WTF::bind(), and removes the hand-rolled code that contains the
repetition for cases with zero to seven bound arguments.

The key trick is to use std::tuple<T...> to pass the types of bound
parameters.

This patch adds a new dependency to base/tuple.h for a simple utility
called base::IndexSequence defined there. The bind code lives in WTF, so
this should be fine.

BUG=565765
Committed: https://crrev.com/2a02e48ea74b0608a2eb43aa935a3cd7dbaea8f2
Cr-Commit-Position: refs/heads/master@{#374319}

[Yuta Kitamura, 2016-02-08 05:09:42]

The CQ bit was checked by yutak@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-08 05:10:09]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1679773002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1679773002/1

[Yuta Kitamura, 2016-02-08 05:31:16]

yutak@chromium.org changed reviewers:
+ haraken@chromium.org, hiroshige@chromium.org, thakis@chromium.org,
tzik@chromium.org

[Yuta Kitamura, 2016-02-08 05:31:17]

Hi, here's my most recent template pasta, sprinkled with
a lot of three dots...

tzik, hiroshige: PTAL?
haraken: as WTF owner
thakis: as base/ owner, for new dependency to base/tuple.h

[Yuta Kitamura, 2016-02-08 06:29:10]

The CQ bit was checked by yutak@chromium.org to run a CQ dry run

[Yuta Kitamura, 2016-02-08 06:29:33]

Thanks to tzik, I could further simplify the patch (PS2).

[commit-bot: I haz the power, 2016-02-08 06:30:10]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1679773002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1679773002/20001

[tzik, 2016-02-08 06:31:17]

lgtm

[haraken, 2016-02-08 06:51:00]

LGTM

[hiroshige, 2016-02-08 07:02:57]

great, lgtm!

[Yuta Kitamura, 2016-02-08 07:56:27]

The CQ bit was checked by yutak@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-08 07:56:49]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1679773002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1679773002/40001

[commit-bot: I haz the power, 2016-02-08 11:48:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-08 11:48:54]

Dry run: This issue passed the CQ dry run.

[Nico, 2016-02-09 03:16:53]

if this lgttzik, it lgtm

https://codereview.chromium.org/1679773002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/wtf/Functional.h (right):

https://codereview.chromium.org/1679773002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/wtf/Functional.h:37: #include <tuple>
It's a bit unfortunate that this includes both base/tuple.h and <tuple>…is this
really both needed?

[Yuta Kitamura, 2016-02-09 05:47:43]

Thanks everyone.

(I highly praise tzik-san for becoming an acronym.)

https://codereview.chromium.org/1679773002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/wtf/Functional.h (right):

https://codereview.chromium.org/1679773002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/wtf/Functional.h:37: #include <tuple>
On 2016/02/09 03:16:53, Nico wrote:
> It's a bit unfortunate that this includes both base/tuple.h and <tuple>…is
this
> really both needed?

The only reason I added base/tuple.h was base::IndexSequence.
IMO it's a general utility and can be moved to a stand-alone
header, but that's something that can be done later.

[Yuta Kitamura, 2016-02-09 05:47:54]

The CQ bit was checked by yutak@chromium.org

[Yuta Kitamura, 2016-02-09 05:47:55]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, hiroshige@chromium.org, tzik@chromium.org
Link to the patchset: https://codereview.chromium.org/1679773002/#ps40001
(title: "Make callInternal() private.")

[commit-bot: I haz the power, 2016-02-09 05:48:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1679773002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1679773002/40001

[commit-bot: I haz the power, 2016-02-09 05:55:15]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-02-09 05:56:34]

Description was changed from

==========
WTF::bind: Remove the need of hand-rolled code for bound arguments.

This patch adds a generalized version of PartBoundFunctionImpl for
WTF::bind(), and removes the hand-rolled code that contains the
repetition for cases with zero to seven bound arguments.

The key trick is to use std::tuple<T...> to pass the types of bound
parameters.

This patch adds a new dependency to base/tuple.h for a simple utility
called base::IndexSequence defined there. The bind code lives in WTF, so
this should be fine.

BUG=565765
==========

to

==========
WTF::bind: Remove the need of hand-rolled code for bound arguments.

This patch adds a generalized version of PartBoundFunctionImpl for
WTF::bind(), and removes the hand-rolled code that contains the
repetition for cases with zero to seven bound arguments.

The key trick is to use std::tuple<T...> to pass the types of bound
parameters.

This patch adds a new dependency to base/tuple.h for a simple utility
called base::IndexSequence defined there. The bind code lives in WTF, so
this should be fine.

BUG=565765

Committed: https://crrev.com/2a02e48ea74b0608a2eb43aa935a3cd7dbaea8f2
Cr-Commit-Position: refs/heads/master@{#374319}
==========

[commit-bot: I haz the power, 2016-02-09 05:56:36]

Patchset 3 (id:??) landed as
https://crrev.com/2a02e48ea74b0608a2eb43aa935a3cd7dbaea8f2
Cr-Commit-Position: refs/heads/master@{#374319}