Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Unified Diff: ipc/attachment_broker.h

Issue 1679763002: Clean up public interface of AttachmentBrokerUnprivileged. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Compile error. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ipc/attachment_broker.h
diff --git a/ipc/attachment_broker.h b/ipc/attachment_broker.h
index 4cf1ab5de587c6407aeb26f7ab478f4000a08eee..f2cdd06be80c22100c0c0a435f07c589f6839d30 100644
--- a/ipc/attachment_broker.h
+++ b/ipc/attachment_broker.h
@@ -97,6 +97,13 @@ class IPC_EXPORT AttachmentBroker : public Listener {
virtual void RegisterCommunicationChannel(Endpoint* endpoint);
virtual void DeregisterCommunicationChannel(Endpoint* endpoint);
+ // In each unprivileged process, exactly one channel should be used to
+ // communicate brokerable attachments with the broker process.
+ virtual void DesignateBrokerCommunicationChannel(Endpoint* endpoint);
+
+ // Whether the process's broker is privileged.
Tom Sepez 2016/02/09 00:26:19 nit: True iff the process's broker is privileged.
erikchen 2016/02/09 02:38:51 Done.
+ virtual bool IsPrivilegedBroker();
Tom Sepez 2016/02/09 00:26:19 Nit: maybe HasPrivilegedBroker(), because this pro
erikchen 2016/02/09 02:38:51 My initial comment was inaccurate in its use of th
+
protected:
using AttachmentVector = std::vector<scoped_refptr<BrokerableAttachment>>;

Powered by Google App Engine
This is Rietveld 408576698