Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 1679743003: CPDF_TextStream::m_pObjArray is always NULL (Closed)

Created:
4 years, 10 months ago by Tom Sepez
Modified:
4 years, 10 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

CPDF_TextStream::m_pObjArray is always NULL Also, use full path to include "text_int.h", as there are two of them; I suspect that fpdf_text_search was including the wrong one as the compiler didn't complain about a signature mismatch I had overlooked. In fact, rename the fxge file to avoid collision completely. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/1d95d654dde9380265be8d412141e03f7ba12da3

Patch Set 1 #

Patch Set 2 : Rename #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -152 lines) Patch
M BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdftext/fpdf_text.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M core/src/fpdftext/fpdf_text_search.cpp View 6 chunks +7 lines, -47 lines 0 comments Download
M core/src/fpdftext/text_int.h View 1 chunk +1 line, -2 lines 0 comments Download
M core/src/fxge/agg/src/fx_agg_driver.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxge/apple/fx_apple_platform.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxge/apple/fx_quartz_device.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxge/ge/fx_ge.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxge/ge/fx_ge_font.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxge/ge/fx_ge_fontmap.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxge/ge/fx_ge_linux.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxge/ge/fx_ge_ps.cpp View 1 1 chunk +2 lines, -1 line 0 comments Download
M core/src/fxge/ge/fx_ge_text.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
A + core/src/fxge/ge/fx_text_int.h View 1 2 chunks +3 lines, -3 lines 1 comment Download
D core/src/fxge/ge/text_int.h View 1 1 chunk +0 lines, -84 lines 0 comments Download
M core/src/fxge/win32/fx_win32_device.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxge/win32/fx_win32_print.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M pdfium.gyp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
Tom Sepez
Pls. review.
4 years, 10 months ago (2016-02-08 18:40:44 UTC) #2
Lei Zhang
lgtm https://codereview.chromium.org/1679743003/diff/20001/core/src/fxge/ge/fx_text_int.h File core/src/fxge/ge/fx_text_int.h (right): https://codereview.chromium.org/1679743003/diff/20001/core/src/fxge/ge/fx_text_int.h#newcode7 core/src/fxge/ge/fx_text_int.h:7: #ifndef CORE_SRC_FXGE_GE_FX_TEXT_INT_H_ Most of the other foo_int.h files ...
4 years, 10 months ago (2016-02-08 20:13:38 UTC) #4
Tom Sepez
4 years, 10 months ago (2016-02-08 20:47:03 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
1d95d654dde9380265be8d412141e03f7ba12da3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698