Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(696)

Issue 1679743002: Add HTML referrerpolicy attribute for area element (Closed)

Created:
4 years, 10 months ago by estark
Modified:
4 years, 10 months ago
CC:
chromium-reviews, blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add HTML referrerpolicy attribute for area element The `referrerpolicy` attribute is implemented for the <area> element via inheritance from HTMLAnchorElement, so this CL enables it by adding it to the IDL and adds tests. BUG=490608 Committed: https://crrev.com/6569abdd1213a68eef95e0ad1ee63df465f2f2aa Cr-Commit-Position: refs/heads/master@{#374101}

Patch Set 1 #

Patch Set 2 : add more tests #

Patch Set 3 : fix webexposed and unsafe-url tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -10 lines) Patch
A + third_party/WebKit/LayoutTests/http/tests/security/referrer-policy-attribute-area-no-referrer.html View 1 chunk +4 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/security/referrer-policy-attribute-area-no-referrer-when-downgrade.html View 1 1 chunk +4 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/security/referrer-policy-attribute-area-origin.html View 1 1 chunk +4 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/security/referrer-policy-attribute-area-origin-when-crossorigin.html View 1 1 chunk +4 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/security/referrer-policy-attribute-area-unsafe-url.html View 1 2 1 chunk +4 lines, -2 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/security/resources/referrer-attr-area-unsafe-url-target.html View 1 2 1 chunk +15 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/element-instance-property-listing-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLAreaElement.idl View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
estark
mkwst, could you PTAL since Jochen is OOO? Thanks!
4 years, 10 months ago (2016-02-08 04:58:10 UTC) #3
Mike West
On 2016/02/08 at 04:58:10, estark wrote: > mkwst, could you PTAL since Jochen is OOO? ...
4 years, 10 months ago (2016-02-08 08:14:29 UTC) #4
estark
On 2016/02/08 08:14:29, Mike West (traveling til 11th) wrote: > On 2016/02/08 at 04:58:10, estark ...
4 years, 10 months ago (2016-02-08 08:28:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1679743002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1679743002/40001
4 years, 10 months ago (2016-02-08 08:28:36 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 10 months ago (2016-02-08 11:52:10 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2016-02-08 11:53:12 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/6569abdd1213a68eef95e0ad1ee63df465f2f2aa
Cr-Commit-Position: refs/heads/master@{#374101}

Powered by Google App Engine
This is Rietveld 408576698