Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Unified Diff: third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.cpp

Issue 1679703002: Revert of Create MediaValuesCached and TokenPreloadScanner on the parser thread (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@TRV_MediaValuesCached
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.cpp
diff --git a/third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.cpp b/third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.cpp
index 4ba4c7590cf6130736c465278da5c853eee7c3fb..ddc46de7168501f4685931938c7b73beb50a55e5 100644
--- a/third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.cpp
+++ b/third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.cpp
@@ -442,7 +442,7 @@
IntegrityMetadataSet m_integrityMetadata;
};
-TokenPreloadScanner::TokenPreloadScanner(const KURL& documentURL, PassOwnPtr<CachedDocumentParameters> documentParameters, const MediaValuesCached::MediaValuesCachedData& mediaValuesCachedData)
+TokenPreloadScanner::TokenPreloadScanner(const KURL& documentURL, PassOwnPtr<CachedDocumentParameters> documentParameters)
: m_documentURL(documentURL)
, m_inStyle(false)
, m_inPicture(false)
@@ -450,10 +450,9 @@
, m_isCSPEnabled(false)
, m_templateCount(0)
, m_documentParameters(documentParameters)
- , m_mediaValues(MediaValuesCached::create(mediaValuesCachedData))
{
ASSERT(m_documentParameters.get());
- ASSERT(m_mediaValues.get());
+ ASSERT(m_documentParameters->mediaValues.get());
}
TokenPreloadScanner::~TokenPreloadScanner()
@@ -490,16 +489,16 @@
scanCommon(token, source, requests);
}
-static void handleMetaViewport(const String& attributeValue, const CachedDocumentParameters* documentParameters, MediaValuesCached* mediaValues)
+static void handleMetaViewport(const String& attributeValue, CachedDocumentParameters* documentParameters)
{
if (!documentParameters->viewportMetaEnabled)
return;
ViewportDescription description(ViewportDescription::ViewportMeta);
HTMLMetaElement::getViewportDescriptionFromContentAttribute(attributeValue, description, nullptr, documentParameters->viewportMetaZeroValuesQuirk);
- FloatSize initialViewport(mediaValues->deviceWidth(), mediaValues->deviceHeight());
+ FloatSize initialViewport(documentParameters->mediaValues->deviceWidth(), documentParameters->mediaValues->deviceHeight());
PageScaleConstraints constraints = description.resolve(initialViewport, documentParameters->defaultViewportMinWidth);
- mediaValues->setViewportHeight(constraints.layoutSize.height());
- mediaValues->setViewportWidth(constraints.layoutSize.width());
+ documentParameters->mediaValues->setViewportHeight(constraints.layoutSize.height());
+ documentParameters->mediaValues->setViewportWidth(constraints.layoutSize.width());
}
static void handleMetaReferrer(const String& attributeValue, CachedDocumentParameters* documentParameters, CSSPreloadScanner* cssScanner)
@@ -511,7 +510,7 @@
}
template <typename Token>
-static void handleMetaNameAttribute(const Token& token, CachedDocumentParameters* documentParameters, MediaValuesCached* mediaValues, CSSPreloadScanner* cssScanner)
+static void handleMetaNameAttribute(const Token& token, CachedDocumentParameters* documentParameters, CSSPreloadScanner* cssScanner)
{
const typename Token::Attribute* nameAttribute = token.getAttributeItem(nameAttr);
if (!nameAttribute)
@@ -524,7 +523,7 @@
String contentAttributeValue(contentAttribute->value);
if (equalIgnoringCase(nameAttributeValue, "viewport")) {
- handleMetaViewport(contentAttributeValue, documentParameters, mediaValues);
+ handleMetaViewport(contentAttributeValue, documentParameters);
return;
}
@@ -608,7 +607,7 @@
return;
}
- handleMetaNameAttribute(token, m_documentParameters.get(), m_mediaValues.get(), &m_cssScanner);
+ handleMetaNameAttribute(token, m_documentParameters.get(), &m_cssScanner);
}
if (match(tagImpl, pictureTag)) {
@@ -617,7 +616,7 @@
return;
}
- StartTagScanner scanner(tagImpl, m_mediaValues);
+ StartTagScanner scanner(tagImpl, m_documentParameters->mediaValues);
scanner.processAttributes(token.attributes());
if (m_inPicture)
scanner.handlePictureSourceURL(m_pictureData);
@@ -642,8 +641,8 @@
}
}
-HTMLPreloadScanner::HTMLPreloadScanner(const HTMLParserOptions& options, const KURL& documentURL, PassOwnPtr<CachedDocumentParameters> documentParameters, const MediaValuesCached::MediaValuesCachedData& mediaValuesCachedData)
- : m_scanner(documentURL, documentParameters, mediaValuesCachedData)
+HTMLPreloadScanner::HTMLPreloadScanner(const HTMLParserOptions& options, const KURL& documentURL, PassOwnPtr<CachedDocumentParameters> documentParameters)
+ : m_scanner(documentURL, documentParameters)
, m_tokenizer(HTMLTokenizer::create(options))
{
}
@@ -679,11 +678,16 @@
preloader->takeAndPreload(requests);
}
-CachedDocumentParameters::CachedDocumentParameters(Document* document)
+CachedDocumentParameters::CachedDocumentParameters(Document* document, PassRefPtrWillBeRawPtr<MediaValuesCached> givenMediaValues)
{
ASSERT(isMainThread());
ASSERT(document);
doHtmlPreloadScanning = !document->settings() || document->settings()->doHtmlPreloadScanning();
+ if (givenMediaValues)
+ mediaValues = givenMediaValues;
+ else
+ mediaValues = MediaValuesCached::create(*document);
+ ASSERT(mediaValues->isSafeToSendToAnotherThread());
defaultViewportMinWidth = document->viewportDefaultMinWidth();
viewportMetaZeroValuesQuirk = document->settings() && document->settings()->viewportMetaZeroValuesQuirk();
viewportMetaEnabled = document->settings() && document->settings()->viewportMetaEnabled();

Powered by Google App Engine
This is Rietveld 408576698