Issue 16797003: Make base use the proper Value namespace

Issue 16797003: Make base use the proper Value namespace (Closed)

Created:
7 years, 6 months ago by brettw

Modified:
7 years, 6 months ago

Reviewers:
Avi (use Gerrit)

CC:
chromium-reviews, erikwright+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Make base compile with no "using base::Value" in values.h This adds explicit namespace to a bunch of places. BUG= R=avi@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=206440

Patch Set 2 : iwarnings fixed #

Total comments: 1

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+204 lines, -188 lines)			Patch
M	base/json/json_file_value_serializer.h	View		3 chunks	+5 lines, -5 lines	0 comments	Download
M	base/json/json_file_value_serializer.cc	View		2 chunks	+6 lines, -5 lines	0 comments	Download
M	base/json/json_string_value_serializer.h	View		3 chunks	+5 lines, -5 lines	0 comments	Download
M	base/json/json_string_value_serializer.cc	View		1 chunk	+2 lines, -0 lines	1 comment	Download
M	base/prefs/default_pref_store.h	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	base/prefs/json_pref_store.cc	View	1	11 chunks	+26 lines, -23 lines	0 comments	Download
M	base/prefs/mock_pref_change_callback.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	base/prefs/mock_pref_change_callback.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	base/prefs/overlay_user_pref_store.cc	View		5 chunks	+5 lines, -5 lines	0 comments	Download
M	base/prefs/pref_member.h	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	base/prefs/pref_member.cc	View		2 chunks	+4 lines, -3 lines	0 comments	Download
M	base/prefs/pref_member_unittest.cc	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	base/prefs/pref_notifier_impl_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	base/prefs/pref_service.cc	View		12 chunks	+40 lines, -37 lines	0 comments	Download
M	base/prefs/pref_service_unittest.cc	View	1	18 chunks	+27 lines, -25 lines	0 comments	Download
M	base/prefs/pref_value_map.cc	View		6 chunks	+9 lines, -8 lines	0 comments	Download
M	base/prefs/pref_value_store.h	View		3 chunks	+4 lines, -4 lines	0 comments	Download
M	base/prefs/pref_value_store.cc	View		5 chunks	+9 lines, -8 lines	0 comments	Download
M	base/prefs/pref_value_store_unittest.cc	View		12 chunks	+16 lines, -16 lines	0 comments	Download
M	base/prefs/testing_pref_service.h	View		9 chunks	+19 lines, -17 lines	0 comments	Download
M	base/prefs/testing_pref_store.cc	View		5 chunks	+8 lines, -7 lines	0 comments	Download
M	base/prefs/value_map_pref_store.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	base/test/trace_event_analyzer.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	base/values.cc	View		2 chunks	+2 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

brettw

https://codereview.chromium.org/16797003/diff/2001/base/json/json_string_value_serializer.cc File base/json/json_string_value_serializer.cc (right): https://codereview.chromium.org/16797003/diff/2001/base/json/json_string_value_serializer.cc#newcode11 base/json/json_string_value_serializer.cc:11: using base::Value; I did a "using" ont his since ...

7 years, 6 months ago (2013-06-13 22:49:30 UTC) #1

Avi (use Gerrit)

LGTM Your description is ungrammatical; I don't know what you mean by "with no using". ...

7 years, 6 months ago (2013-06-13 23:03:49 UTC) #2

brettw

7 years, 6 months ago (2013-06-14 17:56:20 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r206440 (presubmit successful).

Expand Messages | Collapse Messages