Reland of Change default Windows compiler to VS 2015

Reland of Change default Windows compiler to VS 2015 (patchset #1 id:1 of https://codereview.chromium.org/1678663002/ )

Reason for revert:
Issues that forced revert of VS 2015 as default compiler are believed to be fixed.

Original issue's description:
> Revert of Change default Windows compiler to VS 2015 (patchset #10 id:180001 of https://codereview.chromium.org/1598493004/ )
>
> Reason for revert:
> Speculative for https://code.google.com/p/chromium/issues/detail?id=498544#c20 . Will reland if this doesn't help.
>
> Original issue's description:
> > Change default Windows compiler to VS 2015
> >
> > The change to get_landmines.py is there because modifying this file
> > affects analyze behavior so that all tests run. Changing the printed
> > message is purely a side effect.
> >
> > This change also removes some redundant INCLUDE paths. These are
> > unnecessary when building with VS 2015 (because it defaults to the
> > Windows 10 SDK) and actively harmful (they make the INCLUDE path
> > problematically long).
> >
> > BUG=440500, 584782
> >
> > Committed: https://crrev.com/4c17ac0db59d7dbe78734950f83912ab564bd6fe
> > Cr-Commit-Position: refs/heads/master@{#373955}
>
> TBR=dpranke@chromium.org,scottmg@chromium.org,sebmarchand@chromium.org,brucedawson@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=440500, 584782
>
> Committed: https://crrev.com/bbc766aef1bd8cb0d9546fec9abf264e7d8c1d96
> Cr-Commit-Position: refs/heads/master@{#374013}

TBR=dpranke@chromium.org,scottmg@chromium.org,sebmarchand@chromium.org,thakis@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=440500, 584782
Committed: https://crrev.com/20e99ecb08da22582d435c1a5bba0a5c96345da3
Cr-Commit-Position: refs/heads/master@{#374058}

[brucedawson, 2016-02-07 07:06:25]

Created Reland of Change default Windows compiler to VS 2015

[Sébastien Marchand, 2016-02-07 07:10:38]

lgtm

[brucedawson, 2016-02-07 07:23:03]

Current plan, if the tree is open when needed, is to reland this Sunday night
PST. The known issues have been addressed, and the currently running try jobs
include four win_clang bots to double-check that.

[Nico, 2016-02-07 15:16:13]

On 2016/02/07 07:23:03, brucedawson wrote:
> Current plan, if the tree is open when needed, is to reland this Sunday night
> PST. The known issues have been addressed, and the currently running try jobs
> include four win_clang bots to double-check that.

Is there anything wrong with landing this Sunday morning? That way I'm not about
to go to bed if things turn red :-) And most of the waterfall looked pretty
happy when this was in. I'd prefer to cq+ this as soon a possible.

(A word on the win_clang trybots: They are backed by just 3 slaves, and they
don't use goma, so their cycle time is high. It's absolutely fine to use them
for things like toolchain upgrades, but in general please don't use more than
one at once. That's also why win_clang_rel is still running 7h later: The three
slaves had to do the other 3 win_clang bots first, and maybe they were doing
something else so that didn't start immediately, and the cycle time is ~3h due
to no goma. Also, they don't run tests, so they only answer "will it build?")

[brucedawson, 2016-02-07 17:06:08]

> Is there anything wrong with landing this Sunday morning? That way I'm not
about
> to go to bed if things turn red :-) And most of the waterfall looked pretty
> happy when this was in. I'd prefer to cq+ this as soon a possible.

I will be less available in the morning and early afternoon, but that needn't
stop things. Feel free to click the commit button at any time. It's looking
good. Or, more formally, lgtm.

I did local clang=1 tests as well - debug/release component builds and a release
non-component build. All succeeded. So, no known failures.

Thanks for the info on the clang bots.

[Nico, 2016-02-07 18:05:45]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2016-02-07 18:05:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1679693002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1679693002/1

[commit-bot: I haz the power, 2016-02-07 18:17:36]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-02-07 18:19:00]

Description was changed from

==========
Reland of Change default Windows compiler to VS 2015 (patchset #1 id:1 of
https://codereview.chromium.org/1678663002/ )

Reason for revert:
Issues that forced revert of VS 2015 as default compiler are believed to be
fixed.

Original issue's description:
> Revert of Change default Windows compiler to VS 2015 (patchset #10 id:180001
of https://codereview.chromium.org/1598493004/ )
> 
> Reason for revert:
> Speculative for https://code.google.com/p/chromium/issues/detail?id=498544#c20
. Will reland if this doesn't help.
> 
> Original issue's description:
> > Change default Windows compiler to VS 2015
> >
> > The change to get_landmines.py is there because modifying this file
> > affects analyze behavior so that all tests run. Changing the printed
> > message is purely a side effect.
> >
> > This change also removes some redundant INCLUDE paths. These are
> > unnecessary when building with VS 2015 (because it defaults to the
> > Windows 10 SDK) and actively harmful (they make the INCLUDE path
> > problematically long).
> >
> > BUG=440500,584782
> >
> > Committed: https://crrev.com/4c17ac0db59d7dbe78734950f83912ab564bd6fe
> > Cr-Commit-Position: refs/heads/master@{#373955}
> 
>
TBR=dpranke@chromium.org,scottmg@chromium.org,sebmarchand@chromium.org,bruced...
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=440500,584782
> 
> Committed: https://crrev.com/bbc766aef1bd8cb0d9546fec9abf264e7d8c1d96
> Cr-Commit-Position: refs/heads/master@{#374013}

TBR=dpranke@chromium.org,scottmg@chromium.org,sebmarchand@chromium.org,thakis...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=440500,584782
==========

to

==========
Reland of Change default Windows compiler to VS 2015 (patchset #1 id:1 of
https://codereview.chromium.org/1678663002/ )

Reason for revert:
Issues that forced revert of VS 2015 as default compiler are believed to be
fixed.

Original issue's description:
> Revert of Change default Windows compiler to VS 2015 (patchset #10 id:180001
of https://codereview.chromium.org/1598493004/ )
>
> Reason for revert:
> Speculative for https://code.google.com/p/chromium/issues/detail?id=498544#c20
. Will reland if this doesn't help.
>
> Original issue's description:
> > Change default Windows compiler to VS 2015
> >
> > The change to get_landmines.py is there because modifying this file
> > affects analyze behavior so that all tests run. Changing the printed
> > message is purely a side effect.
> >
> > This change also removes some redundant INCLUDE paths. These are
> > unnecessary when building with VS 2015 (because it defaults to the
> > Windows 10 SDK) and actively harmful (they make the INCLUDE path
> > problematically long).
> >
> > BUG=440500,584782
> >
> > Committed: https://crrev.com/4c17ac0db59d7dbe78734950f83912ab564bd6fe
> > Cr-Commit-Position: refs/heads/master@{#373955}
>
>
TBR=dpranke@chromium.org,scottmg@chromium.org,sebmarchand@chromium.org,bruced...
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=440500,584782
>
> Committed: https://crrev.com/bbc766aef1bd8cb0d9546fec9abf264e7d8c1d96
> Cr-Commit-Position: refs/heads/master@{#374013}

TBR=dpranke@chromium.org,scottmg@chromium.org,sebmarchand@chromium.org,thakis...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=440500,584782

Committed: https://crrev.com/20e99ecb08da22582d435c1a5bba0a5c96345da3
Cr-Commit-Position: refs/heads/master@{#374058}
==========

[commit-bot: I haz the power, 2016-02-07 18:19:01]

Patchset 1 (id:??) landed as
https://crrev.com/20e99ecb08da22582d435c1a5bba0a5c96345da3
Cr-Commit-Position: refs/heads/master@{#374058}

[Zhenyao Mo, 2016-02-07 19:42:30]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1680533004/ by zmo@chromium.org.

The reason for reverting is: This breaks GPU win debug bots
(https://build.chromium.org/p/chromium.gpu/builders/Win7%20Debug%20%28NVIDIA%2...
for example, every GPU test is crashing).

[brucedawson, 2016-02-07 20:36:18]

On 2016/02/07 19:42:30, Zhenyao Mo wrote:
> A revert of this CL (patchset #1 id:1) has been created in
> https://codereview.chromium.org/1680533004/ by mailto:zmo@chromium.org.
> 
> The reason for reverting is: This breaks GPU win debug bots
>
(https://build.chromium.org/p/chromium.gpu/builders/Win7%20Debug%20%28NVIDIA%2...
> for example, every GPU test is crashing).

Best guess is that this is a UCRT problem. The debug binaries require that the
Windows 10 Universal CRT be either installed or copied to the same directory as
the executables, and probably either some DLLs were missed or some directory was
missed. The files are api-ms-*.dll and ucrtbase.dll, in addition to the
*140*.dll files.

I don't remember seeing this failure on Friday, which seems odd, so the other
possibility is that this is not actually related to VS 2015. I can investigate
this evening.

[Nico, 2016-02-07 20:53:03]

On 2016/02/07 20:36:18, brucedawson wrote:
> On 2016/02/07 19:42:30, Zhenyao Mo wrote:
> > A revert of this CL (patchset #1 id:1) has been created in
> > https://codereview.chromium.org/1680533004/ by mailto:zmo@chromium.org.
> > 
> > The reason for reverting is: This breaks GPU win debug bots
> >
>
(https://build.chromium.org/p/chromium.gpu/builders/Win7%20Debug%20%28NVIDIA%2...
> > for example, every GPU test is crashing).

FWIW, tests on the clang/win bots fail in a way that looks very similar:
https://build.chromium.org/p/chromium.fyi/builders/CrWinClang%28shared%29%20t...

[Nico, 2016-02-07 21:48:36]

On 2016/02/07 20:53:03, Nico wrote:
> On 2016/02/07 20:36:18, brucedawson wrote:
> > On 2016/02/07 19:42:30, Zhenyao Mo wrote:
> > > A revert of this CL (patchset #1 id:1) has been created in
> > > https://codereview.chromium.org/1680533004/ by mailto:zmo@chromium.org.
> > > 
> > > The reason for reverting is: This breaks GPU win debug bots
> > >
> >
>
(https://build.chromium.org/p/chromium.gpu/builders/Win7%20Debug%20%28NVIDIA%2...
> > > for example, every GPU test is crashing).
> 
> FWIW, tests on the clang/win bots fail in a way that looks very similar:
>
https://build.chromium.org/p/chromium.fyi/builders/CrWinClang%28shared%29%20t...

Hm, they failed like that on the 32-bit release shared bot, but they're passing
on the 32-bit release static bot:
https://build.chromium.org/p/chromium.fyi/builders/CrWinClang%20tester/builds...

In a few hours, a 64-bit release shared bot should complete too, we'll see how
that goes. (The other clang/win tester bots didn't cycle before zmo reverted.)

[brucedawson, 2016-02-08 00:48:05]

I'll investigate later.
On Feb 7, 2016 1:48 PM, <thakis@chromium.org> wrote:

>
> On 2016/02/07 20:53:03, Nico wrote:
> > On 2016/02/07 20:36:18, brucedawson wrote:
> > > On 2016/02/07 19:42:30, Zhenyao Mo wrote:
> > > > A revert of this CL (patchset #1 id:1) has been created in
> > > > https://codereview.chromium.org/1680533004/ by mailto:zmo@chromium.org.
> > > >
> > > > The reason for reverting is: This breaks GPU win debug bots
> > > >
> > >
> >
>
(https://build.chromium.org/p/chromium.gpu/builders/Win7%20Debug%20%28NVIDIA%2...
> > > > for example, every GPU test is crashing).
> >
> > FWIW, tests on the clang/win bots fail in a way that looks very similar:
>
>https://build.chromium.org/p/chromium.fyi/builders/CrWinClang%28shared%29%20tester/builds/3395
>
> Hm, they failed like that on the 32-bit release shared bot, but they're
passing
> on the 32-bit release static
bot:https://build.chromium.org/p/chromium.fyi/builders/CrWinClang%20tester/builds/4180
>
> In a few hours, a 64-bit release shared bot should complete too, we'll see
how
> that goes. (The other clang/win tester bots didn't cycle before zmo
reverted.)
> https://codereview.chromium.org/1679693002/
>
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[brucedawson, 2016-02-09 01:04:49]

The problem was the UCRT DLLs were not all being copied to the out directories,
or being listed in the appropriate .isolate files. crrev.com/1676943002 should
deal with this and will let this change be landed again.