Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1679683004: Revert of Do not eagerly instantiate accessors' JSFunction. (Closed)

Created:
4 years, 10 months ago by Michael Achenbach
Modified:
4 years, 10 months ago
Reviewers:
epertoso, Toon Verwaest
CC:
jochen (gone - plz use gerrit), v8-reviews_googlegroups.com, Toon Verwaest
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Do not eagerly instantiate accessors' JSFunction. (patchset #9 id:180001 of https://codereview.chromium.org/1609233002/ ) Reason for revert: [Sheriff] Breaks gcmole: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20gcmole/builds/6260 Original issue's description: > Do not eagerly instantiate accessors' JSFunction. > > BUG= > > Committed: https://crrev.com/4d46b510caf534d770ce19a01a11b8796304471b > Cr-Commit-Position: refs/heads/master@{#33812} TBR=verwaest@chromium.org,epertoso@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/0e6f0964f0c0c83d1e330c5bc4c96f8479962172 Cr-Commit-Position: refs/heads/master@{#33814}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+263 lines, -390 lines) Patch
M src/api-natives.cc View 9 chunks +33 lines, -43 lines 0 comments Download
M src/arguments.h View 2 chunks +12 lines, -10 lines 0 comments Download
M src/arm/code-stubs-arm.cc View 4 chunks +6 lines, -8 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 4 chunks +6 lines, -8 lines 0 comments Download
M src/builtins.h View 1 chunk +1 line, -1 line 0 comments Download
M src/builtins.cc View 10 chunks +17 lines, -22 lines 0 comments Download
M src/code-stubs.h View 3 chunks +2 lines, -6 lines 0 comments Download
M src/crankshaft/hydrogen.h View 4 chunks +20 lines, -11 lines 0 comments Download
M src/crankshaft/hydrogen.cc View 9 chunks +35 lines, -43 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 4 chunks +6 lines, -8 lines 0 comments Download
M src/ic/arm/handler-compiler-arm.cc View 2 chunks +6 lines, -13 lines 0 comments Download
M src/ic/arm64/handler-compiler-arm64.cc View 2 chunks +6 lines, -13 lines 0 comments Download
M src/ic/call-optimization.h View 2 chunks +1 line, -2 lines 0 comments Download
M src/ic/call-optimization.cc View 2 chunks +7 lines, -22 lines 0 comments Download
M src/ic/ia32/handler-compiler-ia32.cc View 2 chunks +4 lines, -9 lines 0 comments Download
M src/ic/ic.cc View 2 chunks +43 lines, -41 lines 0 comments Download
M src/ic/mips/handler-compiler-mips.cc View 2 chunks +4 lines, -12 lines 0 comments Download
M src/ic/mips64/handler-compiler-mips64.cc View 2 chunks +4 lines, -12 lines 0 comments Download
M src/ic/ppc/handler-compiler-ppc.cc View 2 chunks +7 lines, -13 lines 0 comments Download
M src/ic/x64/handler-compiler-x64.cc View 2 chunks +4 lines, -12 lines 0 comments Download
M src/ic/x87/handler-compiler-x87.cc View 2 chunks +4 lines, -9 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 4 chunks +6 lines, -8 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 4 chunks +6 lines, -8 lines 0 comments Download
M src/objects.cc View 5 chunks +5 lines, -32 lines 0 comments Download
M src/ppc/code-stubs-ppc.cc View 4 chunks +6 lines, -8 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 4 chunks +6 lines, -8 lines 0 comments Download
M src/x87/code-stubs-x87.cc View 4 chunks +6 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Michael Achenbach
Created Revert of Do not eagerly instantiate accessors' JSFunction.
4 years, 10 months ago (2016-02-08 12:47:55 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1679683004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1679683004/1
4 years, 10 months ago (2016-02-08 12:47:59 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-08 12:48:19 UTC) #4
commit-bot: I haz the power
4 years, 10 months ago (2016-02-08 12:48:41 UTC) #6
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/0e6f0964f0c0c83d1e330c5bc4c96f8479962172
Cr-Commit-Position: refs/heads/master@{#33814}

Powered by Google App Engine
This is Rietveld 408576698