Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Unified Diff: native_client_sdk/src/libraries/nacl_io/kernel_proxy.cc

Issue 1679643002: nacl_io: Add SOCK_DGRAM support to socketpair() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: code review feedback Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: native_client_sdk/src/libraries/nacl_io/kernel_proxy.cc
diff --git a/native_client_sdk/src/libraries/nacl_io/kernel_proxy.cc b/native_client_sdk/src/libraries/nacl_io/kernel_proxy.cc
index a141923de0dec3ada5f6a2b3a7d9d10a07a9e908..9ea09ff02c6e5af2fc099728897bd6d2685e8d8d 100644
--- a/native_client_sdk/src/libraries/nacl_io/kernel_proxy.cc
+++ b/native_client_sdk/src/libraries/nacl_io/kernel_proxy.cc
@@ -1824,7 +1824,8 @@ int KernelProxy::socketpair(int domain, int type, int protocol, int* sv) {
return -1;
}
- if (SOCK_STREAM != type) {
+ // TODO(cernekee): mask this off with SOCK_TYPE_MASK first.
+ if (SOCK_STREAM != type && SOCK_DGRAM != type) {
errno = EPROTOTYPE;
return -1;
}
@@ -1850,7 +1851,7 @@ int KernelProxy::socketpair(int domain, int type, int protocol, int* sv) {
}
#endif
- UnixNode* socket = new UnixNode(stream_fs_.get());
+ UnixNode* socket = new UnixNode(stream_fs_.get(), type);
Error rtn = socket->Init(O_RDWR);
if (rtn != 0) {
errno = rtn;
« no previous file with comments | « native_client_sdk/src/libraries/nacl_io/fifo_interface.h ('k') | native_client_sdk/src/libraries/nacl_io/socket/fifo_packet.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698