Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Unified Diff: native_client_sdk/src/libraries/nacl_io/socket/unix_event_emitter.h

Issue 1679643002: nacl_io: Add SOCK_DGRAM support to socketpair() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix unit test failure Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: native_client_sdk/src/libraries/nacl_io/socket/unix_event_emitter.h
diff --git a/native_client_sdk/src/libraries/nacl_io/socket/unix_event_emitter.h b/native_client_sdk/src/libraries/nacl_io/socket/unix_event_emitter.h
index f8c952dd0e3ab905bb596a4d197825c16b9c34e5..eeea9dba24c57c9c2c4ad7728a232585c879f53e 100644
--- a/native_client_sdk/src/libraries/nacl_io/socket/unix_event_emitter.h
+++ b/native_client_sdk/src/libraries/nacl_io/socket/unix_event_emitter.h
@@ -5,7 +5,7 @@
#ifndef LIBRARIES_NACL_IO_SOCKET_UNIX_EVENT_EMITTER_H_
#define LIBRARIES_NACL_IO_SOCKET_UNIX_EVENT_EMITTER_H_
-#include "nacl_io/fifo_char.h"
+#include "nacl_io/fifo_interface.h"
#include "nacl_io/stream/stream_event_emitter.h"
#include "sdk_util/macros.h"
@@ -29,7 +29,7 @@ class UnixEventEmitter : public StreamEventEmitter {
virtual ScopedUnixEventEmitter GetPeerEmitter() = 0;
- static ScopedUnixEventEmitter MakeUnixEventEmitter(size_t size);
+ static ScopedUnixEventEmitter MakeUnixEventEmitter(size_t size, int type);
protected:
UnixEventEmitter() {}
@@ -38,8 +38,8 @@ class UnixEventEmitter : public StreamEventEmitter {
virtual const sdk_util::SimpleLock& GetFifoLock() = 0;
virtual FIFOInterface* in_fifo() { return in_fifoc(); }
virtual FIFOInterface* out_fifo() { return out_fifoc(); }
- virtual FIFOChar* in_fifoc() = 0;
- virtual FIFOChar* out_fifoc() = 0;
+ virtual FIFOInterface* in_fifoc() = 0;
+ virtual FIFOInterface* out_fifoc() = 0;
Sam Clegg 2016/02/08 17:30:55 Can we just drop in_fifoc and out_fifoc now?
cernekee 2016/02/08 22:53:29 Done.
private:
DISALLOW_COPY_AND_ASSIGN(UnixEventEmitter);

Powered by Google App Engine
This is Rietveld 408576698