Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 16796002: Delete the browser-compositor webview render mode (Closed)

Created:
7 years, 6 months ago by joth
Modified:
7 years, 6 months ago
CC:
chromium-reviews, yurys, vsevik, android-webview-reviews_chromium.org, pfeldman
Visibility:
Public.

Description

Delete the browser-compositor webview render mode This mode is now obsolete. Follow-up patches can from content APIs only needed by this, e.g. kEnableWebViewSynchronousAPIs and DIRECT_CONTEXT_ON_DRAW_THREAD. NOTRY=true BUG=179436 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=206108

Patch Set 1 #

Total comments: 1

Patch Set 2 : boliu comment #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -1102 lines) Patch
M android_webview/android_webview.gyp View 4 chunks +0 lines, -8 lines 0 comments Download
M android_webview/browser/aw_devtools_delegate.cc View 2 chunks +2 lines, -11 lines 0 comments Download
D android_webview/browser/browser_view_renderer_impl.h View 1 chunk +0 lines, -144 lines 0 comments Download
D android_webview/browser/browser_view_renderer_impl.cc View 1 chunk +0 lines, -571 lines 0 comments Download
M android_webview/browser/in_process_view_renderer.h View 1 2 chunks +4 lines, -1 line 0 comments Download
M android_webview/browser/in_process_view_renderer.cc View 1 2 3 chunks +33 lines, -1 line 0 comments Download
D android_webview/browser/renderer_host/view_renderer_host.h View 1 chunk +0 lines, -53 lines 0 comments Download
D android_webview/browser/renderer_host/view_renderer_host.cc View 1 chunk +0 lines, -68 lines 0 comments Download
M android_webview/common/aw_switches.h View 1 chunk +0 lines, -3 lines 0 comments Download
M android_webview/common/aw_switches.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M android_webview/common/render_view_messages.h View 2 chunks +0 lines, -12 lines 0 comments Download
D android_webview/common/renderer_picture_map.h View 1 chunk +0 lines, -38 lines 0 comments Download
D android_webview/common/renderer_picture_map.cc View 1 chunk +0 lines, -49 lines 0 comments Download
M android_webview/lib/main/aw_main_delegate.cc View 1 4 chunks +6 lines, -29 lines 0 comments Download
M android_webview/native/aw_contents.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M android_webview/renderer/aw_content_renderer_client.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M android_webview/renderer/aw_render_view_ext.cc View 2 chunks +0 lines, -2 lines 0 comments Download
D android_webview/renderer/view_renderer.h View 1 chunk +0 lines, -39 lines 0 comments Download
D android_webview/renderer/view_renderer.cc View 1 chunk +0 lines, -66 lines 0 comments Download

Messages

Total messages: 19 (0 generated)
joth
Turned out that just deleting this now makes my next cleanup much simpler...
7 years, 6 months ago (2013-06-11 22:42:31 UTC) #1
boliu
lgtm yay! https://codereview.chromium.org/16796002/diff/1/android_webview/lib/main/aw_main_delegate.cc File android_webview/lib/main/aw_main_delegate.cc (right): https://codereview.chromium.org/16796002/diff/1/android_webview/lib/main/aw_main_delegate.cc#newcode29 android_webview/lib/main/aw_main_delegate.cc:29: // TODO(boliu): Remove ths global Allow once ...
7 years, 6 months ago (2013-06-11 22:57:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joth@chromium.org/16796002/7001
7 years, 6 months ago (2013-06-12 16:45:30 UTC) #3
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=8668
7 years, 6 months ago (2013-06-12 17:14:57 UTC) #4
boliu
+palmer for ipc message stamp. This only deletes messages
7 years, 6 months ago (2013-06-12 17:17:50 UTC) #5
palmer
lgtm
7 years, 6 months ago (2013-06-12 19:13:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joth@chromium.org/16796002/7001
7 years, 6 months ago (2013-06-12 19:46:11 UTC) #7
commit-bot: I haz the power
Retried try job too often on linux_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=49769
7 years, 6 months ago (2013-06-12 23:30:47 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joth@chromium.org/16796002/7001
7 years, 6 months ago (2013-06-12 23:34:13 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joth@chromium.org/16796002/7001
7 years, 6 months ago (2013-06-13 03:00:09 UTC) #10
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 6 months ago (2013-06-13 04:57:05 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joth@chromium.org/16796002/7001
7 years, 6 months ago (2013-06-13 06:30:55 UTC) #12
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 6 months ago (2013-06-13 06:39:36 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joth@chromium.org/16796002/7001
7 years, 6 months ago (2013-06-13 08:59:48 UTC) #14
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 6 months ago (2013-06-13 09:04:20 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joth@chromium.org/16796002/7001
7 years, 6 months ago (2013-06-13 10:15:05 UTC) #16
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 6 months ago (2013-06-13 10:18:47 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joth@chromium.org/16796002/89001
7 years, 6 months ago (2013-06-13 17:40:15 UTC) #18
commit-bot: I haz the power
7 years, 6 months ago (2013-06-13 17:44:33 UTC) #19
Message was sent while issue was closed. 
Change committed as 206108

Powered by Google App Engine
This is Rietveld 408576698