cc: Remove the --enable-partial-swap flag.

cc: Remove the --enable-partial-swap flag.

This flag only affects the cc::GLRenderer which is only
used when ubercomp is disabled. This means non-aura platforms.

On these platforms, the --enable-partial-swap flag is
never set, so we can turn it off permanently for non-ubercomp
renderer compositors. This removes the whole "AllowPartialSwap"
concept from content/renderer/ along with the command line
flag.


R=piman
BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251898

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252362

[piman, 2014-02-14 23:55:10]

lgtm

[danakj, 2014-02-15 00:08:41]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2014-02-15 00:18:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/danakj@chromium.org/167953003/1

[commit-bot: I haz the power, 2014-02-15 03:57:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-15 03:57:52]

Retried try job too often on win_rel for step(s) unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[danakj, 2014-02-18 22:23:21]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2014-02-18 22:24:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/danakj@chromium.org/167953003/1

[commit-bot: I haz the power, 2014-02-19 00:32:42]

Change committed as 251898

[danakj, 2014-02-19 18:44:31]

A revert of this CL has been created in
https://codereview.chromium.org/172763002/ by danakj@chromium.org.

The reason for reverting is: Should have only enabled this on ChromeOS. Enabled
elsewhere by mistake..

[danakj, 2014-02-19 18:46:12]

Updated CL to only enable this on ChromeOS as that's the only place that the
flag was passed in.

[danakj, 2014-02-19 20:46:42]

Set partial swap flag in the renderer on !USE_AURA where we don't have ubercomp
as that's the only platforms it affects. Disable test that turns off ubercomp on
USE_AURA.

[danakj, 2014-02-19 20:48:51]

+fsamuel,sadrul FYI

disabling the BrowserPluginThreadedCompositorPixelTest.GetBackingStore test on
aura, as it would start causing us to add if statements to prod code to keep it
working.

[danakj, 2014-02-19 20:49:28]

+fsamuel,sadrul FYI

disabling the BrowserPluginThreadedCompositorPixelTest.GetBackingStore test on
aura, as it would start causing us to add if statements to prod code to keep it
working.

(actually +'d)

[Fady Samuel, 2014-02-19 20:51:20]

browser_pluign_host_browsertest LGTM

[sadrul, 2014-02-19 20:52:18]

https://codereview.chromium.org/167953003/diff/590001/content/browser/browser...
File content/browser/browser_plugin/browser_plugin_host_browsertest.cc (right):

https://codereview.chromium.org/167953003/diff/590001/content/browser/browser...
content/browser/browser_plugin/browser_plugin_host_browsertest.cc:894: #if
defined(OS_MACOSX) || defined(USE_AURA)
Mind updating the comment to include crbug 327035?

[danakj, 2014-02-19 20:58:21]

Ok removed the whole AllowPartialSwap thing from content/renderer.

[danakj, 2014-02-19 21:02:42]

https://codereview.chromium.org/167953003/diff/590001/content/browser/browser...
File content/browser/browser_plugin/browser_plugin_host_browsertest.cc (right):

https://codereview.chromium.org/167953003/diff/590001/content/browser/browser...
content/browser/browser_plugin/browser_plugin_host_browsertest.cc:894: #if
defined(OS_MACOSX) || defined(USE_AURA)
On 2014/02/19 20:52:18, sadrul wrote:
> Mind updating the comment to include crbug 327035?

Done.

[danakj, 2014-02-19 21:08:55]

+kenrb for content/common/view_messages.h : Deleting an IPC member.

[kenrb, 2014-02-19 21:09:55]

lgtm

[piman, 2014-02-20 00:34:47]

lgtm

[danakj, 2014-02-20 17:52:43]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2014-02-20 17:54:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/danakj@chromium.org/167953003/790001

[commit-bot: I haz the power, 2014-02-20 20:15:33]

Change committed as 252362