Drop frames until first IDR in VTVDA.

Drop frames until first IDR in VTVDA.

This allows us to decode streams that incorrectly mark every frame
as a keyframe; we will drop frames until the first IDR and configure the
decoder then.

When this happens we log an error; it will show up in chrome://gpu (and
stderr).

This does mean that we are delaying decode failure (possibly indefinitely)
in that case.

BUG=229412, 583638, 583698, 516039
Committed: https://crrev.com/8a2f5658c6301691342e302ea618c61cad5d220c
Cr-Commit-Position: refs/heads/master@{#373964}

[sandersd (OOO until July 31), 2016-02-05 22:27:52]

The CQ bit was checked by sandersd@chromium.org to run a CQ dry run

[sandersd (OOO until July 31), 2016-02-05 22:28:09]

sandersd@chromium.org changed reviewers:
+ dalecurtis@chromium.org, wolenetz@chromium.org

[sandersd (OOO until July 31), 2016-02-05 22:28:48]

Description was changed from

==========
Drop frames until first IDR in VTVDA.

This allows us to decode streams that are incorrectly mark every frame
as a keyframe; we will drop frames until the first IDR and configure the
decoder then.

This does mean that we are delaying decode failure possible indefinitely
in that case.

BUG=229412
==========

to

==========
Drop frames until first IDR in VTVDA.

This allows us to decode streams that are incorrectly mark every frame
as a keyframe; we will drop frames until the first IDR and configure the
decoder then.

When this happens we log an error; it will show up in chrome://gpu (and
stderr).

This does mean that we are delaying decode failure possible indefinitely
in that case.

BUG=229412
==========

[sandersd (OOO until July 31), 2016-02-05 22:29:19]

Description was changed from

==========
Drop frames until first IDR in VTVDA.

This allows us to decode streams that are incorrectly mark every frame
as a keyframe; we will drop frames until the first IDR and configure the
decoder then.

When this happens we log an error; it will show up in chrome://gpu (and
stderr).

This does mean that we are delaying decode failure possible indefinitely
in that case.

BUG=229412
==========

to

==========
Drop frames until first IDR in VTVDA.

This allows us to decode streams that incorrectly mark every frame
as a keyframe; we will drop frames until the first IDR and configure the
decoder then.

When this happens we log an error; it will show up in chrome://gpu (and
stderr).

This does mean that we are delaying decode failure possible indefinitely
in that case.

BUG=229412
==========

[commit-bot: I haz the power, 2016-02-05 22:29:41]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1679503002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1679503002/1

[sandersd (OOO until July 31), 2016-02-05 22:29:58]

Description was changed from

==========
Drop frames until first IDR in VTVDA.

This allows us to decode streams that incorrectly mark every frame
as a keyframe; we will drop frames until the first IDR and configure the
decoder then.

When this happens we log an error; it will show up in chrome://gpu (and
stderr).

This does mean that we are delaying decode failure possible indefinitely
in that case.

BUG=229412
==========

to

==========
Drop frames until first IDR in VTVDA.

This allows us to decode streams that incorrectly mark every frame
as a keyframe; we will drop frames until the first IDR and configure the
decoder then.

When this happens we log an error; it will show up in chrome://gpu (and
stderr).

This does mean that we are delaying decode failure (possibly indefinitely)
in that case.

BUG=229412
==========

[DaleCurtis, 2016-02-05 22:35:27]

https://codereview.chromium.org/1679503002/diff/1/content/common/gpu/media/vt...
File content/common/gpu/media/vt_video_decode_accelerator_mac.cc (right):

https://codereview.chromium.org/1679503002/diff/1/content/common/gpu/media/vt...
content/common/gpu/media/vt_video_decode_accelerator_mac.cc:649: LOG(ERROR) <<
"Illegal attempt to decode without IDR. Dropping frame.";
DLOG(). Don't want to spam console on bad streams.

Notably, these dropped frames won't be counted, which is unfortunate, but
arguable depending on what you want to define a frame as :)

[wolenetz, 2016-02-05 22:52:06]

LGTM % :
* --log spam per dalecurtis@
* in description (ideally in BUG= line), reference also the known bugs (for the
bad streams) that this CL fixes.

[commit-bot: I haz the power, 2016-02-05 23:16:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-05 23:16:56]

Dry run: This issue passed the CQ dry run.

[sandersd (OOO until July 31), 2016-02-05 23:24:39]

Description was changed from

==========
Drop frames until first IDR in VTVDA.

This allows us to decode streams that incorrectly mark every frame
as a keyframe; we will drop frames until the first IDR and configure the
decoder then.

When this happens we log an error; it will show up in chrome://gpu (and
stderr).

This does mean that we are delaying decode failure (possibly indefinitely)
in that case.

BUG=229412
==========

to

==========
Drop frames until first IDR in VTVDA.

This allows us to decode streams that incorrectly mark every frame
as a keyframe; we will drop frames until the first IDR and configure the
decoder then.

When this happens we log an error; it will show up in chrome://gpu (and
stderr).

This does mean that we are delaying decode failure (possibly indefinitely)
in that case.

BUG=229412,583638,583698,516039
==========

[sandersd (OOO until July 31), 2016-02-05 23:24:54]

https://codereview.chromium.org/1679503002/diff/1/content/common/gpu/media/vt...
File content/common/gpu/media/vt_video_decode_accelerator_mac.cc (right):

https://codereview.chromium.org/1679503002/diff/1/content/common/gpu/media/vt...
content/common/gpu/media/vt_video_decode_accelerator_mac.cc:649: LOG(ERROR) <<
"Illegal attempt to decode without IDR. Dropping frame.";
On 2016/02/05 22:35:27, DaleCurtis wrote:
> DLOG(). Don't want to spam console on bad streams.
> 
> Notably, these dropped frames won't be counted, which is unfortunate, but
> arguable depending on what you want to define a frame as :)

I've changed it to be limited to once per VTVDA instance. PTAL.

[sandersd (OOO until July 31), 2016-02-05 23:24:59]

The CQ bit was checked by sandersd@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-05 23:25:56]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1679503002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1679503002/20001

[wolenetz, 2016-02-05 23:32:29]

lgtm2

[DaleCurtis, 2016-02-05 23:50:08]

lgtm

https://codereview.chromium.org/1679503002/diff/20001/content/common/gpu/medi...
File content/common/gpu/media/vt_video_decode_accelerator_mac.cc (right):

https://codereview.chromium.org/1679503002/diff/20001/content/common/gpu/medi...
content/common/gpu/media/vt_video_decode_accelerator_mac.cc:653:
missing_idr_logged_ = true;
Do you want to reset this to false after the first real IDR?

[wolenetz, 2016-02-05 23:52:47]

On 2016/02/05 23:50:08, DaleCurtis wrote:
> lgtm
> 
>
https://codereview.chromium.org/1679503002/diff/20001/content/common/gpu/medi...
> File content/common/gpu/media/vt_video_decode_accelerator_mac.cc (right):
> 
>
https://codereview.chromium.org/1679503002/diff/20001/content/common/gpu/medi...
> content/common/gpu/media/vt_video_decode_accelerator_mac.cc:653:
> missing_idr_logged_ = true;
> Do you want to reset this to false after the first real IDR?

Can session_ become unset after being set without decode error already
occurring?

[sandersd (OOO until July 31), 2016-02-05 23:53:52]

https://codereview.chromium.org/1679503002/diff/20001/content/common/gpu/medi...
File content/common/gpu/media/vt_video_decode_accelerator_mac.cc (right):

https://codereview.chromium.org/1679503002/diff/20001/content/common/gpu/medi...
content/common/gpu/media/vt_video_decode_accelerator_mac.cc:653:
missing_idr_logged_ = true;
On 2016/02/05 23:50:08, DaleCurtis wrote:
> Do you want to reset this to false after the first real IDR?

We could do that, but I'm mostly just concerned with making sure there is a log
message at all. One other option would be to switch from LOG to DLOG after the
first message.

[commit-bot: I haz the power, 2016-02-06 00:07:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-06 00:07:15]

Dry run: This issue passed the CQ dry run.

[sandersd (OOO until July 31), 2016-02-06 00:10:08]

The CQ bit was checked by sandersd@chromium.org

[sandersd (OOO until July 31), 2016-02-06 00:10:08]

The patchset sent to the CQ was uploaded after l-g-t-m from
wolenetz@chromium.org
Link to the patchset: https://codereview.chromium.org/1679503002/#ps20001
(title: "Reduce spam.")

[commit-bot: I haz the power, 2016-02-06 00:11:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1679503002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1679503002/20001

[commit-bot: I haz the power, 2016-02-06 00:23:31]

Description was changed from

==========
Drop frames until first IDR in VTVDA.

This allows us to decode streams that incorrectly mark every frame
as a keyframe; we will drop frames until the first IDR and configure the
decoder then.

When this happens we log an error; it will show up in chrome://gpu (and
stderr).

This does mean that we are delaying decode failure (possibly indefinitely)
in that case.

BUG=229412,583638,583698,516039
==========

to

==========
Drop frames until first IDR in VTVDA.

This allows us to decode streams that incorrectly mark every frame
as a keyframe; we will drop frames until the first IDR and configure the
decoder then.

When this happens we log an error; it will show up in chrome://gpu (and
stderr).

This does mean that we are delaying decode failure (possibly indefinitely)
in that case.

BUG=229412,583638,583698,516039
==========

[commit-bot: I haz the power, 2016-02-06 00:23:32]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-02-06 00:24:46]

Description was changed from

==========
Drop frames until first IDR in VTVDA.

This allows us to decode streams that incorrectly mark every frame
as a keyframe; we will drop frames until the first IDR and configure the
decoder then.

When this happens we log an error; it will show up in chrome://gpu (and
stderr).

This does mean that we are delaying decode failure (possibly indefinitely)
in that case.

BUG=229412,583638,583698,516039
==========

to

==========
Drop frames until first IDR in VTVDA.

This allows us to decode streams that incorrectly mark every frame
as a keyframe; we will drop frames until the first IDR and configure the
decoder then.

When this happens we log an error; it will show up in chrome://gpu (and
stderr).

This does mean that we are delaying decode failure (possibly indefinitely)
in that case.

BUG=229412,583638,583698,516039

Committed: https://crrev.com/8a2f5658c6301691342e302ea618c61cad5d220c
Cr-Commit-Position: refs/heads/master@{#373964}
==========

[commit-bot: I haz the power, 2016-02-06 00:24:47]

Patchset 2 (id:??) landed as
https://crrev.com/8a2f5658c6301691342e302ea618c61cad5d220c
Cr-Commit-Position: refs/heads/master@{#373964}