Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 1679433003: Check that all elements are associated with nodes when resolving using an existing element model (Closed)

Created:
4 years, 10 months ago by Brian Wilkerson
Modified:
4 years, 10 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Check that all elements are associated with nodes when resolving using an existing element model R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/5e615e9c3118f783c1ab883686e5acac5a1ab781

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -0 lines) Patch
A pkg/analyzer/lib/src/dart/element/utilities.dart View 1 chunk +34 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/resolver.dart View 9 chunks +34 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
This is the follow-on CL that checks that all elements in an element model are ...
4 years, 10 months ago (2016-02-05 22:17:01 UTC) #2
scheglov
LGTM
4 years, 10 months ago (2016-02-05 22:19:28 UTC) #3
Brian Wilkerson
4 years, 10 months ago (2016-02-05 22:25:37 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5e615e9c3118f783c1ab883686e5acac5a1ab781 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698