build/landmines.py - Issue 167943002: Don't raise for GYP_GENERATORS=dump_dependency_json, don't warn when using gyp_env

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/landmines.py

Issue 167943002: Don't raise for GYP_GENERATORS=dump_dependency_json, don't warn when using gyp_env (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: . Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/landmines.py

diff --git a/build/landmines.py b/build/landmines.py

index 7b4c5b5ecc623ff88b553f2ca5f8ffed4e8fa12f..857585adbfa6b84bf2ccf07d4c4e2aedd9f4592e 100755

--- a/build/landmines.py

+++ b/build/landmines.py

@@ -15,7 +15,6 @@ build is clobbered.

"""

import difflib

-import gyp_helper

import logging

import optparse

import os

@@ -113,7 +112,9 @@ def process_options():

def main():

landmine_scripts = process_options()

- gyp_helper.apply_chromium_gyp_env()

+ if landmine_utils.builder() == 'dump_dependency_json':

+ return 0

for target in ('Debug', 'Release', 'Debug_x64', 'Release_x64'):

landmines = []

« no previous file with comments | « no previous file | no next file » | no next file with comments »