Don't raise for GYP_GENERATORS=dump_dependency_json, don't warn when using gyp_env

Don't raise for GYP_GENERATORS=dump_dependency_json, don't warn when using gyp_env

R=thakis@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251536

[scottmg, 2014-02-14 23:45:14]

I don't think landmines.py is run elsewhere that uses chromium.gyp_env, but this
might be bad if it is.

This is the only place I can see, but hopefully bots don't use chromium.gyp_env?

https://code.google.com/p/chromium/codesearch#chromium/src/build/android/buil...

[Nico, 2014-02-14 23:47:44]

lgtm I guess.

Once the msvs transition is done, can landmines.py move back into a regular
build step?

[scottmg, 2014-02-14 23:51:23]

On 2014/02/14 23:47:44, Nico (away Feb 11 - Feb 17) wrote:
> lgtm I guess.
> 
> Once the msvs transition is done, can landmines.py move back into a regular
> build step?

No, it's in there so that the stuff above that sets GYP_* in the environment is
taken into account when landmines run.

e.g. starting at
https://code.google.com/p/chromium/codesearch#chromium/src/build/gyp_chromium...

[scottmg, 2014-02-14 23:56:52]

The CQ bit was checked by scottmg@chromium.org

[Nico, 2014-02-14 23:57:23]

On Fri, Feb 14, 2014 at 3:51 PM, <scottmg@chromium.org> wrote:

> On 2014/02/14 23:47:44, Nico (away Feb 11 - Feb 17) wrote:
>
>> lgtm I guess.
>>
>
>  Once the msvs transition is done, can landmines.py move back into a
>> regular
>> build step?
>>
>
> No, it's in there so that the stuff above that sets GYP_* in the
> environment is
> taken into account when landmines run.
>

But the generator bits are reflected in landmines too, no? Those are kept
in sync manually. And all the GYP_MSVS stuff can go away once we're on 2013
everywhere?


>
> e.g. starting at
> https://code.google.com/p/chromium/codesearch#chromium/
> src/build/gyp_chromium&l=429
>
> https://codereview.chromium.org/167943002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2014-02-15 00:00:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/scottmg@chromium.org/167943002/30001

[scottmg, 2014-02-15 00:02:33]

I'm not sure what you mean by manually. If I don't set GYP_GENERATORS, then
landmines doesn't know that GENERATOR I'm using, unless it's run from
within gyp_chromium.

The GYP_MSVS_VERSION setting could go away, yes.

I think it's better to have it run as close as possible to where gyp.main
is run though.


On Fri, Feb 14, 2014 at 3:57 PM, Nico Weber <thakis@chromium.org> wrote:

> On Fri, Feb 14, 2014 at 3:51 PM, <scottmg@chromium.org> wrote:
>
>> On 2014/02/14 23:47:44, Nico (away Feb 11 - Feb 17) wrote:
>>
>>> lgtm I guess.
>>>
>>
>>  Once the msvs transition is done, can landmines.py move back into a
>>> regular
>>> build step?
>>>
>>
>> No, it's in there so that the stuff above that sets GYP_* in the
>> environment is
>> taken into account when landmines run.
>>
>
> But the generator bits are reflected in landmines too, no? Those are kept
> in sync manually. And all the GYP_MSVS stuff can go away once we're on 2013
> everywhere?
>
>
>>
>> e.g. starting at
>> https://code.google.com/p/chromium/codesearch#chromium/
>> src/build/gyp_chromium&l=429
>>
>> https://codereview.chromium.org/167943002/
>>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[scottmg, 2014-02-15 00:02:56]

Oh, I see what you mean in linemine_utils.builder now. Sigh, whatever I
guess.


On Fri, Feb 14, 2014 at 4:02 PM, Scott Graham <scottmg@chromium.org> wrote:

> I'm not sure what you mean by manually. If I don't set GYP_GENERATORS,
> then landmines doesn't know that GENERATOR I'm using, unless it's run from
> within gyp_chromium.
>
> The GYP_MSVS_VERSION setting could go away, yes.
>
> I think it's better to have it run as close as possible to where gyp.main
> is run though.
>
>
> On Fri, Feb 14, 2014 at 3:57 PM, Nico Weber <thakis@chromium.org> wrote:
>
>> On Fri, Feb 14, 2014 at 3:51 PM, <scottmg@chromium.org> wrote:
>>
>>> On 2014/02/14 23:47:44, Nico (away Feb 11 - Feb 17) wrote:
>>>
>>>> lgtm I guess.
>>>>
>>>
>>>  Once the msvs transition is done, can landmines.py move back into a
>>>> regular
>>>> build step?
>>>>
>>>
>>> No, it's in there so that the stuff above that sets GYP_* in the
>>> environment is
>>> taken into account when landmines run.
>>>
>>
>> But the generator bits are reflected in landmines too, no? Those are kept
>> in sync manually. And all the GYP_MSVS stuff can go away once we're on 2013
>> everywhere?
>>
>>
>>>
>>> e.g. starting at
>>> https://code.google.com/p/chromium/codesearch#chromium/
>>> src/build/gyp_chromium&l=429
>>>
>>> https://codereview.chromium.org/167943002/
>>>
>>
>>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2014-02-15 05:23:33]

Change committed as 251536

[iannucci, 2014-02-19 00:03:11]

'lgtm'

agree w/ grumbles. grumble-inducing system induces grumbles. should fix.