Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1679373002: Disable reg-exp compilation in background via a flag (Closed)

Created:
4 years, 10 months ago by srdjan
Modified:
4 years, 10 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Disable reg-exp compilation in background via a flag; abort background compilation if deoptimization needs to be triggered while compiling; Both issues will be fixed later BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/c5ea105261b5ecf96f8edec692e2151f264c960c

Patch Set 1 #

Patch Set 2 : flag #

Patch Set 3 : n #

Patch Set 4 : b #

Total comments: 2

Patch Set 5 : Sync problem #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -27 lines) Patch
M runtime/vm/code_generator.cc View 1 2 2 chunks +7 lines, -1 line 0 comments Download
M runtime/vm/compiler.cc View 1 2 3 4 2 chunks +6 lines, -13 lines 0 comments Download
M runtime/vm/flow_graph.h View 2 chunks +0 lines, -5 lines 0 comments Download
M runtime/vm/flow_graph.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/flow_graph_optimizer.cc View 1 2 3 2 chunks +8 lines, -4 lines 0 comments Download
M runtime/vm/parser.cc View 3 chunks +3 lines, -1 line 0 comments Download
M runtime/vm/regexp.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
srdjan
4 years, 10 months ago (2016-02-09 19:16:08 UTC) #2
rmacnak
lgtm w/c https://codereview.chromium.org/1679373002/diff/60001/runtime/vm/compiler.cc File runtime/vm/compiler.cc (right): https://codereview.chromium.org/1679373002/diff/60001/runtime/vm/compiler.cc#newcode523 runtime/vm/compiler.cc:523: if (!FLAG_precompilation) { Always true as precompiled ...
4 years, 10 months ago (2016-02-09 20:26:11 UTC) #4
srdjan
https://codereview.chromium.org/1679373002/diff/60001/runtime/vm/compiler.cc File runtime/vm/compiler.cc (right): https://codereview.chromium.org/1679373002/diff/60001/runtime/vm/compiler.cc#newcode523 runtime/vm/compiler.cc:523: if (!FLAG_precompilation) { On 2016/02/09 20:26:11, rmacnak wrote: > ...
4 years, 10 months ago (2016-02-09 20:44:43 UTC) #5
srdjan
4 years, 10 months ago (2016-02-09 20:48:36 UTC) #7
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) manually as
c5ea105261b5ecf96f8edec692e2151f264c960c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698