Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1679363002: Tests that --fields_may_be_reset, --link_natives_lazily, and --no_allow_absolute_addresses work in … (Closed)

Created:
4 years, 10 months ago by rmacnak
Modified:
4 years, 10 months ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Tests that --fields_may_be_reset, --link_natives_lazily, and --no_allow_absolute_addresses work in the JIT. Minor change to make --no_allow_aboslute_address to work in the (non-IA32) JIT. R=fschneider@google.com Committed: https://github.com/dart-lang/sdk/commit/65063a0927a3ae9f4814ec83d9d8c117621d42ec

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -19 lines) Patch
M runtime/vm/intermediate_language_arm.cc View 1 chunk +9 lines, -4 lines 0 comments Download
M runtime/vm/intermediate_language_arm64.cc View 1 chunk +9 lines, -4 lines 0 comments Download
M runtime/vm/intermediate_language_mips.cc View 1 chunk +9 lines, -4 lines 0 comments Download
M runtime/vm/intermediate_language_x64.cc View 1 chunk +8 lines, -3 lines 0 comments Download
M runtime/vm/isolate.h View 1 chunk +3 lines, -0 lines 0 comments Download
A + tests/standalone/fields_may_be_reset_test.dart View 1 chunk +1 line, -1 line 0 comments Download
A + tests/standalone/link_natives_lazily_test.dart View 1 chunk +1 line, -1 line 0 comments Download
A + tests/standalone/no_allow_absolute_addresses_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/no_lazy_dispatchers_test.dart View 1 chunk +1 line, -1 line 1 comment Download
M tests/standalone/standalone.status View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
rmacnak
https://codereview.chromium.org/1679363002/diff/1/tests/standalone/no_lazy_dispatchers_test.dart File tests/standalone/no_lazy_dispatchers_test.dart (right): https://codereview.chromium.org/1679363002/diff/1/tests/standalone/no_lazy_dispatchers_test.dart#newcode5 tests/standalone/no_lazy_dispatchers_test.dart:5: // VMOptions=--no_lazy_dispatchers Switching to underscores so string searches of ...
4 years, 10 months ago (2016-02-09 19:00:53 UTC) #2
Florian Schneider
lgtm
4 years, 10 months ago (2016-02-10 09:50:36 UTC) #3
rmacnak
4 years, 10 months ago (2016-02-11 17:53:39 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
65063a0927a3ae9f4814ec83d9d8c117621d42ec (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698