Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 1679343004: Revert of Sk4f: add floor() (Closed)

Created:
4 years, 10 months ago by mtklein
Modified:
4 years, 10 months ago
Reviewers:
herb_g, mtklein_C
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Sk4f: add floor() (patchset #3 id:40001 of https://codereview.chromium.org/1685773002/ ) Reason for revert: build break must be this, right? Original issue's description: > Sk4f: add floor() > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1685773002 > CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot > > Committed: https://skia.googlesource.com/skia/+/86c6c4935171a1d2d6a9ffbff37ec6dac1326614 TBR=herb@google.com,mtklein@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/c023210893da7ca407bad8c9f07c8339ee81854c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -59 lines) Patch
M bench/Sk4fBench.cpp View 1 chunk +0 lines, -16 lines 0 comments Download
M src/core/SkNx.h View 3 chunks +1 line, -4 lines 0 comments Download
M src/opts/SkNx_neon.h View 2 chunks +0 lines, -19 lines 0 comments Download
M src/opts/SkNx_sse.h View 2 chunks +0 lines, -12 lines 0 comments Download
M tests/SkNxTest.cpp View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
mtklein
Created Revert of Sk4f: add floor()
4 years, 10 months ago (2016-02-09 23:10:47 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1679343004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1679343004/1
4 years, 10 months ago (2016-02-09 23:10:51 UTC) #2
commit-bot: I haz the power
4 years, 10 months ago (2016-02-09 23:11:00 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/c023210893da7ca407bad8c9f07c8339ee81854c

Powered by Google App Engine
This is Rietveld 408576698