third_party/WebKit/Source/core/editing/commands/EditCommand.h - Issue 1679253002: Editing: Add EditingState* argument to EditCommand::doApply.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/EditCommand.h

Issue 1679253002: Editing: Add EditingState* argument to EditCommand::doApply. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp ('k') | third_party/WebKit/Source/core/editing/commands/EditCommand.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/EditCommand.h

diff --git a/third_party/WebKit/Source/core/editing/commands/EditCommand.h b/third_party/WebKit/Source/core/editing/commands/EditCommand.h

index 3e2bddbc90453e0fc9f9e73114f161b47a8995cd..18a3b1197b607dddd9bc8636726236a9c55d5692 100644

--- a/third_party/WebKit/Source/core/editing/commands/EditCommand.h

+++ b/third_party/WebKit/Source/core/editing/commands/EditCommand.h

@@ -34,6 +34,7 @@ namespace blink {

class CompositeEditCommand;

class Document;

+class EditingState;

class EditCommand : public RefCountedWillBeGarbageCollectedFinalized<EditCommand> {

public:

@@ -50,7 +51,8 @@ public:

virtual bool isCompositeEditCommand() const { return false; }

bool isTopLevelCommand() const { return !m_parent; }

- virtual void doApply() = 0;

+ // The |EditingState*| argument must not be nullptr.

+ virtual void doApply(EditingState*) = 0;

DECLARE_VIRTUAL_TRACE();