chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java - Issue 1679223003: [NTP Snippets] Make a base::Feature instead of raw cmdline flag

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

Issue 1679223003: [NTP Snippets] Make a base::Feature instead of raw cmdline flag (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@may_ntp

Patch Set: rebase Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

index 9d1eb0a030869ddb82f670e1808c944c0b7cc80a..ec7b1099df39529e48b2361efe7d2f811e8ec89d 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

@@ -696,7 +696,7 @@ public abstract class ChromeActivity extends AsyncInitializationActivity

recordKeyboardLocaleUma();

// TODO(treib): Remove this when we have the proper morning reads fetching logic in place

- if (CommandLine.getInstance().hasSwitch(ChromeSwitches.ENABLE_NTP_SNIPPETS)) {

+ if (ChromeFeatureList.isEnabled(ChromeFeatureList.NTP_SNIPPETS)) {

// Initialize snippets

SnippetsController.get(this).fetchSnippets(false);

}

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java » ('j') | no next file with comments »